From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54163) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cEKX5-0003QY-Ok for qemu-devel@nongnu.org; Tue, 06 Dec 2016 13:32:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cEKX1-0005xP-NR for qemu-devel@nongnu.org; Tue, 06 Dec 2016 13:32:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41160) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cEKX1-0005wv-HA for qemu-devel@nongnu.org; Tue, 06 Dec 2016 13:31:59 -0500 From: Aaron Conole References: <20161130101017.13382-1-maxime.coquelin@redhat.com> <20161130101017.13382-3-maxime.coquelin@redhat.com> Date: Tue, 06 Dec 2016 13:31:55 -0500 In-Reply-To: <20161130101017.13382-3-maxime.coquelin@redhat.com> (Maxime Coquelin's message of "Wed, 30 Nov 2016 11:10:16 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [RFC v3 2/3] vhost-net: Notify the backend about the host MTU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Maxime Coquelin Cc: mst@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, fbl@redhat.com, berrange@redhat.com, mlureau@redhat.com, ktraynor@redhat.com, jasowang@redhat.com, yuanhan.liu@linux.intel.com Maxime Coquelin writes: > This patch provides a way for virtio-net to notify the > backend about the host MTU set by the user. > > Cc: Michael S. Tsirkin > Cc: Aaron Conole > Signed-off-by: Maxime Coquelin > --- > hw/net/vhost_net.c | 22 ++++++++++++++++++++++ > include/net/vhost_net.h | 2 ++ > 2 files changed, 24 insertions(+) > > diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c > index f2d49ad..d7c13d4 100644 > --- a/hw/net/vhost_net.c > +++ b/hw/net/vhost_net.c > @@ -51,6 +51,7 @@ static const int kernel_feature_bits[] = { > VIRTIO_RING_F_EVENT_IDX, > VIRTIO_NET_F_MRG_RXBUF, > VIRTIO_F_VERSION_1, > + VIRTIO_NET_F_MTU, > VHOST_INVALID_FEATURE_BIT > }; > > @@ -74,6 +75,7 @@ static const int user_feature_bits[] = { > VIRTIO_NET_F_HOST_ECN, > VIRTIO_NET_F_HOST_UFO, > VIRTIO_NET_F_MRG_RXBUF, > + VIRTIO_NET_F_MTU, > > /* This bit implies RARP isn't sent by QEMU out of band */ > VIRTIO_NET_F_GUEST_ANNOUNCE, > @@ -435,6 +437,22 @@ int vhost_set_vring_enable(NetClientState *nc, int enable) > return 0; > } > > +int vhost_net_set_mtu(struct vhost_net *net, uint16_t mtu) > +{ > + const VhostOps *vhost_ops = net->dev.vhost_ops; > + int ret; > + > + if (!vhost_ops->vhost_net_set_mtu) { > + return -ENOSYS; > + } > + > + ret = vhost_ops->vhost_net_set_mtu(&net->dev, mtu); > + if (ret < 0) { > + return -errno; > + } > + return 0; > +} > + > #else > uint64_t vhost_net_get_max_queues(VHostNetState *net) > { > @@ -501,4 +519,8 @@ int vhost_set_vring_enable(NetClientState *nc, int enable) > { > return 0; > } > + > +int vhost_net_set_mtu(struct vhost_net *net, uint16_t mtu) > +{ > +} > #endif I think this should return something - I don't know what value will come through if it doesn't :). > diff --git a/include/net/vhost_net.h b/include/net/vhost_net.h > index 5a08eff..afc1499 100644 > --- a/include/net/vhost_net.h > +++ b/include/net/vhost_net.h > @@ -35,4 +35,6 @@ int vhost_set_vring_enable(NetClientState * nc, int enable); > > uint64_t vhost_net_get_acked_features(VHostNetState *net); > > +int vhost_net_set_mtu(struct vhost_net *net, uint16_t mtu); > + > #endif