From: Aaron Conole <aconole@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, thomas@monjalon.net,
Michael Santana <maicolgabriel@hotmail.com>
Subject: Re: [PATCH v2 2/2] ci: install libvirt
Date: Thu, 14 Nov 2024 08:51:55 -0500 [thread overview]
Message-ID: <f7t4j497wjo.fsf@redhat.com> (raw)
In-Reply-To: <20241112140107.1916734-2-david.marchand@redhat.com> (David Marchand's message of "Tue, 12 Nov 2024 15:01:06 +0100")
David Marchand <david.marchand@redhat.com> writes:
> Install libvirt so that vm_power_manager example compilation is tested.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
LGTM
Acked-by: Aaron Conole <aconole@redhat.com>
> .github/workflows/build.yml | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
> index f7d3affbaa..067862d96a 100644
> --- a/.github/workflows/build.yml
> +++ b/.github/workflows/build.yml
> @@ -107,7 +107,7 @@ jobs:
> - name: Install packages
> run: sudo apt install -y ccache libarchive-dev libbsd-dev libbpf-dev
> libfdt-dev libibverbs-dev libipsec-mb-dev libisal-dev libjansson-dev
> - libnuma-dev libpcap-dev libssl-dev ninja-build pkg-config python3-pip
> + libnuma-dev libpcap-dev libssl-dev libvirt-dev ninja-build pkg-config python3-pip
> python3-pyelftools python3-setuptools python3-wheel zlib1g-dev
> - name: Install libabigail build dependencies if no cache is available
> if: env.ABI_CHECKS == 'true' && steps.libabigail-cache.outputs.cache-hit != 'true'
> @@ -196,8 +196,8 @@ jobs:
> if: steps.image_cache.outputs.cache-hit != 'true'
> run: docker exec -i dpdk dnf install -y ccache intel-ipsec-mb-devel
> isa-l-devel jansson-devel libarchive-devel libatomic libbsd-devel
> - libbpf-devel libfdt-devel libpcap-devel libxdp-devel ninja-build
> - numactl-devel openssl-devel python3-pip python3-pyelftools
> + libbpf-devel libfdt-devel libpcap-devel libvirt-devel libxdp-devel
> + ninja-build numactl-devel openssl-devel python3-pip python3-pyelftools
> python3-setuptools python3-wheel rdma-core-devel zlib-devel
> - name: Save image in cache
> if: steps.image_cache.outputs.cache-hit != 'true'
> @@ -271,8 +271,8 @@ jobs:
> - name: Install packages
> run: docker exec -i dpdk dnf install -y ccache intel-ipsec-mb-devel
> isa-l-devel jansson-devel libarchive-devel libatomic libbsd-devel
> - libbpf-devel libfdt-devel libpcap-devel libxdp-devel ninja-build
> - numactl-devel openssl-devel python3-pip python3-pyelftools
> + libbpf-devel libfdt-devel libpcap-devel libvirt-devel libxdp-devel
> + ninja-build numactl-devel openssl-devel python3-pip python3-pyelftools
> python3-setuptools python3-wheel rdma-core-devel zlib-devel
> ${{ matrix.config.compiler }}
> - name: Run setup
next prev parent reply other threads:[~2024-11-14 13:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 10:34 [PATCH 1/2] power: fix build with libvirt David Marchand
2024-11-12 10:34 ` [PATCH 2/2] ci: install libvirt David Marchand
2024-11-12 14:01 ` [PATCH v2 1/2] power: fix build with libvirt David Marchand
2024-11-12 14:01 ` [PATCH v2 2/2] ci: install libvirt David Marchand
2024-11-14 13:51 ` Aaron Conole [this message]
2024-11-12 14:23 ` [PATCH v2 1/2] power: fix build with libvirt David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7t4j497wjo.fsf@redhat.com \
--to=aconole@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=maicolgabriel@hotmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.