From: Aaron Conole <aconole@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: mst@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org,
jasowang@redhat.com, yuanhan.liu@linux.intel.com
Subject: Re: [Qemu-devel] [RFC v2 2/3] vhost-net: Add new MTU feature support
Date: Fri, 18 Nov 2016 13:13:19 -0500 [thread overview]
Message-ID: <f7t4m34k668.fsf@redhat.com> (raw)
In-Reply-To: <1479419887-10515-3-git-send-email-maxime.coquelin@redhat.com> (Maxime Coquelin's message of "Thu, 17 Nov 2016 22:58:06 +0100")
Maxime Coquelin <maxime.coquelin@redhat.com> writes:
> If VHOST_USER_F_MTU feature is negociated, vhost-net makes the
> advised MTU available to virtio-net through a vhost_net_get_mtu()
s/advised/maximum/
> call.
>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Cc: Aaron Conole <aconole@redhat.com>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
> hw/net/vhost_net.c | 11 +++++++++++
> include/net/vhost_net.h | 2 ++
> 2 files changed, 13 insertions(+)
>
> diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
> index f2d49ad..21057d6 100644
> --- a/hw/net/vhost_net.c
> +++ b/hw/net/vhost_net.c
> @@ -74,6 +74,7 @@ static const int user_feature_bits[] = {
> VIRTIO_NET_F_HOST_ECN,
> VIRTIO_NET_F_HOST_UFO,
> VIRTIO_NET_F_MRG_RXBUF,
> + VIRTIO_NET_F_MTU,
>
> /* This bit implies RARP isn't sent by QEMU out of band */
> VIRTIO_NET_F_GUEST_ANNOUNCE,
> @@ -435,6 +436,11 @@ int vhost_set_vring_enable(NetClientState *nc, int enable)
> return 0;
> }
>
> +uint64_t vhost_net_get_mtu(struct vhost_net *net)
> +{
> + return net->dev.mtu;
> +}
> +
> #else
> uint64_t vhost_net_get_max_queues(VHostNetState *net)
> {
> @@ -501,4 +507,9 @@ int vhost_set_vring_enable(NetClientState *nc, int enable)
> {
> return 0;
> }
> +
> +uint64_t vhost_net_get_mtu(struct vhost_net *net)
> +{
> + return 0;
> +}
> #endif
> diff --git a/include/net/vhost_net.h b/include/net/vhost_net.h
> index 5a08eff..37de17b 100644
> --- a/include/net/vhost_net.h
> +++ b/include/net/vhost_net.h
> @@ -35,4 +35,6 @@ int vhost_set_vring_enable(NetClientState * nc, int enable);
>
> uint64_t vhost_net_get_acked_features(VHostNetState *net);
>
> +uint64_t vhost_net_get_mtu(struct vhost_net *net);
> +
> #endif
next prev parent reply other threads:[~2016-11-18 18:13 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 21:58 [Qemu-devel] [RFC v2 0/3] virtio-net: Add support to MTU feature Maxime Coquelin
2016-11-17 21:58 ` [Qemu-devel] [RFC v2 1/3] vhost-user: Add new protocol feature MTU Maxime Coquelin
2016-11-18 14:26 ` Aaron Conole
2016-11-21 12:50 ` Maxime Coquelin
2016-11-17 21:58 ` [Qemu-devel] [RFC v2 2/3] vhost-net: Add new MTU feature support Maxime Coquelin
2016-11-17 22:39 ` Michael S. Tsirkin
2016-11-21 12:51 ` Maxime Coquelin
2016-11-18 18:13 ` Aaron Conole [this message]
2016-11-17 21:58 ` [Qemu-devel] [RFC v2 3/3] virtio-net: Add " Maxime Coquelin
2016-11-17 22:38 ` Michael S. Tsirkin
2016-11-21 12:34 ` Maxime Coquelin
2016-11-21 16:48 ` Michael S. Tsirkin
2016-11-22 12:11 ` Maxime Coquelin
2016-11-22 14:18 ` Michael S. Tsirkin
2016-11-22 15:33 ` Maxime Coquelin
2016-11-17 22:34 ` [Qemu-devel] [RFC v2 0/3] virtio-net: Add support to MTU feature Michael S. Tsirkin
2016-11-18 6:42 ` John Fastabend
2016-11-18 18:15 ` Aaron Conole
2016-11-18 18:52 ` Maxime Coquelin
2016-11-18 19:21 ` Aaron Conole
2016-11-21 16:23 ` Michael S. Tsirkin
2016-11-22 4:07 ` Jason Wang
2016-11-22 7:40 ` Maxime Coquelin
2016-11-22 14:32 ` Aaron Conole
2016-11-22 14:41 ` Michael S. Tsirkin
2016-11-22 17:56 ` Maxime Coquelin
2016-11-22 20:38 ` Michael S. Tsirkin
2016-11-23 3:42 ` Jason Wang
2016-11-23 4:26 ` Michael S. Tsirkin
2016-11-23 14:02 ` Aaron Conole
2016-11-23 17:42 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7t4m34k668.fsf@redhat.com \
--to=aconole@redhat.com \
--cc=jasowang@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.