From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F8A518E377 for ; Wed, 14 May 2025 14:14:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747232079; cv=none; b=Xes/G9PfC94kAXLSVVxOENr52fmI76LfUdcyfzyqkBeFYxUenX51s/loQXBL2YJcRnusU6Xr6BM+gbTXGwYTX8DnGVBgRtG5eakuaw5thU9nASSHi57tOe1B/Wou+7R7yWBSzdmv92uV1i+4ArI8bYoKO26ilAhLNTrWrSl3IaQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747232079; c=relaxed/simple; bh=r+rdiSnfS0ewBDl2wJtTSwpAvJKY5lt9tHzxYmbOs1E=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=bFBYZbP33HwcuH+avYnIvycEGOQ+aQ+3pEOMyJJHrzAsfJMDZvKQDBqv8TC73qPal2bOItBt1pMjLo6Lci1JELmaMVvPosaCqqhen/34Tczbh67zq3UzId03JYNP8x6y9ZaQA62x3RcBZbzCCi3YNYzHCX1XZMWoNRQRgt5QgSM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=f46RyjPv; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="f46RyjPv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747232077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r+rdiSnfS0ewBDl2wJtTSwpAvJKY5lt9tHzxYmbOs1E=; b=f46RyjPvXHawHirEpLBWfyvvEV1i/lZ+j1IRErZzVZxuJfoxCCPltnUdDJvzbsD7gTaUVa 08Gqd5eKquLWSNpaqwJdW2xuz+WCPNlQMu3K/+mYDiLr9jSW7Pcy0R9tFELbKQAjahnsz+ mJiQj57A05AZzdGD8ri9EO6Y5/gJMWk= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-66-dTX38y8GPuSRWNTzDXh5RA-1; Wed, 14 May 2025 10:14:30 -0400 X-MC-Unique: dTX38y8GPuSRWNTzDXh5RA-1 X-Mimecast-MFC-AGG-ID: dTX38y8GPuSRWNTzDXh5RA_1747232069 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E59EC1800360; Wed, 14 May 2025 14:14:28 +0000 (UTC) Received: from RHTRH0061144 (unknown [10.22.88.72]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 34765180049D; Wed, 14 May 2025 14:14:25 +0000 (UTC) From: Aaron Conole To: Sebastian Andrzej Siewior Cc: netdev@vger.kernel.org, linux-rt-devel@lists.linux.dev, dev@openvswitch.org, Ilya Maximets , Eric Dumazet , Simon Horman , Jakub Kicinski , Thomas Gleixner , Paolo Abeni , "David S. Miller" Subject: Re: [ovs-dev] [PATCH net-next v4 09/15] openvswitch: Move ovs_frag_data_storage into the struct ovs_pcpu_storage In-Reply-To: <20250512092736.229935-10-bigeasy@linutronix.de> (Sebastian Andrzej Siewior's message of "Mon, 12 May 2025 11:27:30 +0200") References: <20250512092736.229935-1-bigeasy@linutronix.de> <20250512092736.229935-10-bigeasy@linutronix.de> Date: Wed, 14 May 2025 10:14:24 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-rt-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Sebastian Andrzej Siewior writes: > ovs_frag_data_storage is a per-CPU variable and relies on disabled BH for its > locking. Without per-CPU locking in local_bh_disable() on PREEMPT_RT > this data structure requires explicit locking. > > Move ovs_frag_data_storage into the struct ovs_pcpu_storage which already > provides locking for the structure. > > Cc: Aaron Conole > Cc: Eelco Chaudron > Cc: Ilya Maximets > Cc: dev@openvswitch.org > Signed-off-by: Sebastian Andrzej Siewior > --- Reviewed-by: Aaron Conole