Re: [PATCH] ci: build with MSVC in GHA

[Aaron Conole <aconole@redhat.com>]

David Marchand <david.marchand@redhat.com> writes:

> On Tue, Feb 18, 2025 at 2:32 PM Aaron Conole <aconole@redhat.com> wrote:
>>
>> David Marchand <david.marchand@redhat.com> writes:
>>
>> > Add a build target in Windows 2022 for MSVC.
>> >
>> > Loading MSVC environment and having successive commands in a single
>> > (cmd or pwsh) shell does not seem to correctly report if one of the
>> > commands failed.
>> > For now, load MSVC environment and run commands in separate shells.
>> >
>> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>> > ---
>>
>> LGTM.
>>
>> Acked-by: Aaron Conole <aconole@redhat.com>
>>
>> How far back will this work (ie: can we backport this to older branches?)
>
> MSVC was added in 23.11.
> The patch applies cleanly and runs on 23.11 (where only lib/kvargs,
> lib/log and lib/telemetry are compiled) and 24.11.
>
> I can add Cc: stable if you think it is worth having it in LTS (UNH
> provides some coverage in LTS releases).

I usually prefer to back-port CI related changes because it helps us
catch issues / improve the stable release cycle.