From: Aaron Conole <aconole@redhat.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
dev@openvswitch.org, davem@davemloft.net, kuba@kernel.org,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Pravin B Shelar <pshelar@ovn.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Florian Westphal <fw@strlen.de>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Davide Caratti <dcaratti@redhat.com>
Subject: Re: [PATCH net-next 1/3] netfilter: allow exp not to be removed in nf_ct_find_expectation
Date: Wed, 19 Jul 2023 12:07:22 -0400 [thread overview]
Message-ID: <f7t8rbb7umd.fsf@redhat.com> (raw)
In-Reply-To: <74bd67f806666fd9a3975ae441c308128409ea32.1689541664.git.lucien.xin@gmail.com> (Xin Long's message of "Sun, 16 Jul 2023 17:09:17 -0400")
Xin Long <lucien.xin@gmail.com> writes:
> Currently nf_conntrack_in() calling nf_ct_find_expectation() will
> remove the exp from the hash table. However, in some scenario, we
> expect the exp not to be removed when the created ct will not be
> confirmed, like in OVS and TC conntrack in the following patches.
>
> This patch allows exp not to be removed by setting IPS_CONFIRMED
> in the status of the tmpl.
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
LGTM
Acked-by: Aaron Conole <aconole@redhat.com>
next prev parent reply other threads:[~2023-07-19 16:07 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-16 21:09 [PATCH net-next 0/3] net: handle the exp removal problem with ovs upcall properly Xin Long
2023-07-16 21:09 ` [PATCH net-next 1/3] netfilter: allow exp not to be removed in nf_ct_find_expectation Xin Long
2023-07-19 16:07 ` Aaron Conole [this message]
2023-07-16 21:09 ` [PATCH net-next 2/3] net: sched: set IPS_CONFIRMED in tmpl status only when commit is set in act_ct Xin Long
2023-07-19 16:07 ` Aaron Conole
2023-07-19 16:44 ` Davide Caratti
2023-07-16 21:09 ` [PATCH net-next 3/3] openvswitch: set IPS_CONFIRMED in tmpl status only when commit is set in conntrack Xin Long
2023-07-19 16:08 ` Aaron Conole
2024-06-17 20:10 ` Ilya Maximets
2024-06-18 11:34 ` Ilya Maximets
2024-06-18 14:58 ` Xin Long
2024-06-18 15:50 ` Ilya Maximets
2024-06-19 12:58 ` Ilya Maximets
2024-06-19 14:07 ` Xin Long
2024-06-19 17:30 ` Ilya Maximets
2024-06-19 20:11 ` Xin Long
2024-06-19 20:19 ` Florian Westphal
2024-06-19 20:50 ` Xin Long
2024-06-19 21:20 ` Florian Westphal
2024-06-19 22:10 ` Xin Long
2024-07-08 22:03 ` Xin Long
2024-07-08 22:38 ` Florian Westphal
2024-07-09 1:49 ` Xin Long
2024-07-09 5:49 ` Florian Westphal
2023-07-19 2:58 ` [PATCH net-next 0/3] net: handle the exp removal problem with ovs upcall properly Jakub Kicinski
2023-07-19 3:01 ` Florian Westphal
2023-07-19 16:12 ` Florian Westphal
2023-07-19 13:31 ` Aaron Conole
2023-07-20 8:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7t8rbb7umd.fsf@redhat.com \
--to=aconole@redhat.com \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=dev@openvswitch.org \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=pshelar@ovn.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.