From: Aaron Conole <aconole@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: kjlx@templeofstupid.com, maheshb@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH] Ipvlan should return an error when an address is already in use.
Date: Tue, 03 Jan 2017 14:24:43 -0500 [thread overview]
Message-ID: <f7ta8b87xqc.fsf@redhat.com> (raw)
In-Reply-To: <20170103.105528.1616978923771083764.davem@davemloft.net> (David Miller's message of "Tue, 03 Jan 2017 10:55:28 -0500 (EST)")
David Miller <davem@davemloft.net> writes:
> From: Aaron Conole <aconole@redhat.com>
> Date: Tue, 03 Jan 2017 10:50:00 -0500
>
>>> @@ -489,7 +490,12 @@ static int __inet_insert_ifa(struct in_ifaddr *ifa, struct nlmsghdr *nlh,
>>> Notifier will trigger FIB update, so that
>>> listeners of netlink will know about new ifaddr */
>>> rtmsg_ifa(RTM_NEWADDR, ifa, nlh, portid);
>>> - blocking_notifier_call_chain(&inetaddr_chain, NETDEV_UP, ifa);
>>> + ret = blocking_notifier_call_chain(&inetaddr_chain, NETDEV_UP, ifa);
>>
>> Why are you doing this assignment if you aren't using the result?
>>
>>> + ret = notifier_to_errno(ret);
>>> + if (ret) {
>>> + __inet_del_ifa(in_dev, ifap, 1, NULL, portid);
>>> + return ret;
>>> + }
>
> 'ret' assignment is being used, via notifier_to_errno().
d'oh! should have had more coffee - sorry for the noise.
next prev parent reply other threads:[~2017-01-03 19:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-31 4:10 [PATCH] Ipvlan should return an error when an address is already in use Krister Johansen
2017-01-02 3:26 ` David Miller
2017-01-04 10:04 ` Krister Johansen
2017-06-08 20:12 ` [PATCH v2 net-next] " Krister Johansen
2017-06-09 16:26 ` David Miller
2017-06-09 17:13 ` Krister Johansen
2017-06-09 17:15 ` David Miller
2017-06-09 17:25 ` Krister Johansen
2017-01-03 15:50 ` [PATCH] " Aaron Conole
2017-01-03 15:55 ` David Miller
2017-01-03 19:24 ` Aaron Conole [this message]
2017-01-04 10:09 ` Krister Johansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7ta8b87xqc.fsf@redhat.com \
--to=aconole@redhat.com \
--cc=davem@davemloft.net \
--cc=kjlx@templeofstupid.com \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.