Re: [RFC] net: openvswitch: Inroduce a light-weight socket map concept.

[Aaron Conole <aconole@redhat.com>]

Eric Dumazet <edumazet@google.com> writes:

> On Fri, Jun 27, 2025 at 2:55 PM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
>>
>> On Fri, 27 Jun 2025 17:00:54 -0400
>> Aaron Conole <aconole@redhat.com> wrote:
>>
>> > diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
>> > index 429fb34b075e..f43f905b1cb0 100644
>> > --- a/net/ipv4/tcp_ipv4.c
>> > +++ b/net/ipv4/tcp_ipv4.c
>> > @@ -93,6 +93,7 @@ static int tcp_v4_md5_hash_hdr(char *md5_hash,
>> > const struct tcp_md5sig_key *key,
>> >  #endif
>> >
>> >  struct inet_hashinfo tcp_hashinfo;
>> > +EXPORT_SYMBOL(tcp_hashinfo);
>>
>> EXPORT_SYMBOL_GPL seems better here
>
> Even better, not use tcp_hashinfo at all, it will break for netns
> having private hash tables.
>
> Instead use :
>
> struct inet_hashinfo *hinfo = net->ipv4.tcp_death_row.hashinfo

Thanks Eric - I'll make sure to use that in future.