From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Conole Subject: Re: [PATCH -next 1/2] virtio: Start feature MTU support Date: Thu, 02 Jun 2016 13:10:03 -0400 Message-ID: References: <1464882211-18723-1-git-send-email-aconole@redhat.com> <1464882211-18723-2-git-send-email-aconole@redhat.com> <20160602191702-mutt-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160602191702-mutt-send-email-mst@redhat.com> (Michael S. Tsirkin's message of "Thu, 2 Jun 2016 19:17:17 +0300") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: "Michael S. Tsirkin" Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org "Michael S. Tsirkin" writes: > On Thu, Jun 02, 2016 at 11:43:30AM -0400, Aaron Conole wrote: >> This commit adds the feature bit and associated mtu device entry for the >> virtio network device. Future commits will make use of these bits to >> support negotiated MTU. > > why split it out? Pls squash with the next patch. Okay. I thought the usual method was make a commit which introduces the data structure changes, and then make a commit which hooks it up. I'll squash this in the future. >> Signed-off-by: Aaron Conole >> --- >> include/uapi/linux/virtio_net.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h >> index ec32293..751ff59 100644 >> --- a/include/uapi/linux/virtio_net.h >> +++ b/include/uapi/linux/virtio_net.h >> @@ -73,6 +73,8 @@ struct virtio_net_config { >> * Legal values are between 1 and 0x8000 >> */ >> __u16 max_virtqueue_pairs; >> + /* Default maximum transmit unit advice */ >> + __u16 mtu; >> } __attribute__((packed)); >> >> /* >> -- >> 2.5.5 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161529AbcFBRKI (ORCPT ); Thu, 2 Jun 2016 13:10:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38783 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161376AbcFBRKG (ORCPT ); Thu, 2 Jun 2016 13:10:06 -0400 From: Aaron Conole To: "Michael S. Tsirkin" Cc: virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next 1/2] virtio: Start feature MTU support References: <1464882211-18723-1-git-send-email-aconole@redhat.com> <1464882211-18723-2-git-send-email-aconole@redhat.com> <20160602191702-mutt-send-email-mst@redhat.com> Date: Thu, 02 Jun 2016 13:10:03 -0400 In-Reply-To: <20160602191702-mutt-send-email-mst@redhat.com> (Michael S. Tsirkin's message of "Thu, 2 Jun 2016 19:17:17 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 02 Jun 2016 17:10:05 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Michael S. Tsirkin" writes: > On Thu, Jun 02, 2016 at 11:43:30AM -0400, Aaron Conole wrote: >> This commit adds the feature bit and associated mtu device entry for the >> virtio network device. Future commits will make use of these bits to >> support negotiated MTU. > > why split it out? Pls squash with the next patch. Okay. I thought the usual method was make a commit which introduces the data structure changes, and then make a commit which hooks it up. I'll squash this in the future. >> Signed-off-by: Aaron Conole >> --- >> include/uapi/linux/virtio_net.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h >> index ec32293..751ff59 100644 >> --- a/include/uapi/linux/virtio_net.h >> +++ b/include/uapi/linux/virtio_net.h >> @@ -73,6 +73,8 @@ struct virtio_net_config { >> * Legal values are between 1 and 0x8000 >> */ >> __u16 max_virtqueue_pairs; >> + /* Default maximum transmit unit advice */ >> + __u16 mtu; >> } __attribute__((packed)); >> >> /* >> -- >> 2.5.5