Re: [net-next,v4] selftests/net/openvswitch: add SCTP flow key test

[Aaron Conole <aconole@redhat.com>]

Minxi Hou <houminxi@gmail.com> writes:

> Add test_sctp_connect_v4() to verify OVS can match on SCTP flow keys
> (sctp src/dst port).
> 
> The test sets up client and server namespaces connected through an
> OVS bridge, installs port-keyed flows, and verifies:
>   - sctp(dst=4443) matches client-to-server INIT
>   - sctp(src=4443) matches server-to-client INIT-ACK
>   - removing flows drops the connection
>   - reinstalling flows restores connectivity
> 
> Signed-off-by: Minxi Hou <houminxi@gmail.com>
> ---
>  .../selftests/net/openvswitch/openvswitch.sh  | 105 ++++++++++++++++++
>  .../selftests/net/openvswitch/ovs-dpctl.py    |   5 +
>  2 files changed, 110 insertions(+)
> 
> v3 -> v4: rebase onto latest net-next (2026-07-19), resolve test list
>   conflict from merged trunc test

Hi Minxi,

Just a note that this will conflict with the current in-flight patch::

   [+]   1. #14675655 [new             ] [net-next,v5]
       selftests/net/openvswitch: add ICMPv6 echo type match test
   
It would be best to wait before reposting, or to bundle all of your test
case updates in a single series.

Given the other patch is already reviewed by me, let's wait until that
is accepted upstream before reposting this.  I know Ilya had some
comments about it previously, but haven't checked to see if you've
addressed all of them.  And a nit:

[...]

> +# sctp_connect_v4 test
> +# - sctp(dst=4443) matches client-to-server INIT
> +# - sctp(src=4443) matches server-to-client INIT-ACK
> +# - remove flows and verify connection fails, reinstall and recover
> +test_sctp_connect_v4() {
> +	local t="test_sctp_connect_v4"
> +
> +	which nc >/dev/null 2>&1 || return $ksft_skip
> +	nc --sctp -z 127.0.0.1 1 </dev/null 2>/dev/null || return $ksft_skip

This can probably be instead::

  nc --help 2>&1 | grep -q -- --sctp || return $ksft_skip

This reads nicer to detect SCTP support in 'nc' binary.