All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aaron Conole <aconole@redhat.com>
To: David Young <dave@youngcopy.com>
Cc: dev@dpdk.org,  Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] Updated to dpdk20.11
Date: Thu, 29 Jun 2023 14:26:41 -0400	[thread overview]
Message-ID: <f7tpm5ektum.fsf@redhat.com> (raw)
In-Reply-To: <20230629181209.400-1-dave@youngcopy.com> (David Young's message of "Thu, 29 Jun 2023 14:12:08 -0400")

Hi David,

David Young <dave@youngcopy.com> writes:

> ---

Thanks for the contribution!  Very happy to have someone working on the
docs.  Thanks for getting a patch to the mailing list.  Just a few
nits to address before the patch can get merged.

Customarily, a change to each area will describe that in the subject -
ie:

  docs: freebsd: Update to 20.11

Then in the message body, we can add a bit extra detailing why the
change was needed:

  The docs were specifying to install the dpdk package, but this is
  ambiguous/didn't work/blah blah blah...

Finally, just before the end, we add a DCO sign-off tag:

  Signed-off-by: David Young <dave@youngcopy.com>

When replying for a v2, v3, etc., you will need to reply to the most
recent version which was obsoleted (in this case, git send-email \
--in-reply-to="<20230629181209.400-1-dave@youngcopy.com>") and make sure
that the [PATCH] metadata line includes the text v2.

Thanks!

>  doc/guides/freebsd_gsg/install_from_ports.rst | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guides/freebsd_gsg/install_from_ports.rst b/doc/guides/freebsd_gsg/install_from_ports.rst
> index d946f3f3b2..ae866cd879 100644
> --- a/doc/guides/freebsd_gsg/install_from_ports.rst
> +++ b/doc/guides/freebsd_gsg/install_from_ports.rst
> @@ -23,7 +23,7 @@ Installing the DPDK Package for FreeBSD
>  
>  DPDK can be installed on FreeBSD using the command::
>  
> -	pkg install dpdk
> +	pkg install dpdk20.11
>  
>  After the installation of the DPDK package, instructions will be printed on
>  how to install the kernel modules required to use the DPDK. A more
> @@ -51,7 +51,7 @@ a pre-compiled binary package.
>  On a system with the ports collection installed in ``/usr/ports``, the DPDK
>  can be installed using the commands::
>  
> -    cd /usr/ports/net/dpdk
> +    cd /usr/ports/net/dpdk20.11
>  
>      make install
>  
> @@ -123,3 +123,4 @@ via the contigmem module, and 4 NIC ports bound to the nic_uio module::
>  
>     For an explanation of the command-line parameters that can be passed to an
>     DPDK application, see section :ref:`running_sample_app`.
> +


  reply	other threads:[~2023-06-29 18:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-29 18:12 [PATCH] Updated to dpdk20.11 David Young
2023-06-29 18:26 ` Aaron Conole [this message]
2023-06-30 16:41 ` [PATCH v2] docs: freebsd: Update to 20.11 David Young
2023-07-03 15:19   ` Thomas Monjalon
2023-07-17 13:35     ` Bruce Richardson
2023-07-06 20:36 ` [PATCH v3] " David Young
2024-10-04 16:01   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7tpm5ektum.fsf@redhat.com \
    --to=aconole@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=dave@youngcopy.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.