From: Aaron Conole <aconole@redhat.com>
To: Flavio Leitner <fbl@sysclose.org>
Cc: dpdk <dev@dpdk.org>
Subject: Re: [PATCH] eal: check cpu flags at init
Date: Thu, 29 Sep 2016 16:42:02 -0400 [thread overview]
Message-ID: <f7ttwcyv3ol.fsf@redhat.com> (raw)
In-Reply-To: <20160927183237.GA27384@plex> (Flavio Leitner's message of "Tue, 27 Sep 2016 15:32:37 -0300")
Flavio Leitner <fbl@sysclose.org> writes:
> On Mon, Sep 26, 2016 at 11:43:37AM -0400, Aaron Conole wrote:
>> My only concern is whether this change would be considered ABI
>> breaking. I wouldn't think so, since it doesn't seem as though an
>> application would want to call this explicitly (and is spelled out as
>> such), but I can't be sure that it isn't already included in the
>> standard application API, and therefore needs to go through the change
>> process.
>
> I didn't want to change the original behavior more than needed.
>
> I think another patch would be necessary to change the whole EAL
> initialization because there's a bunch of rte_panic() there which
> aren't friendly with callers either.
Okay makes sense.
Acked-by: Aaron Conole <aconole@redhat.com>
next prev parent reply other threads:[~2016-09-29 20:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 14:47 [PATCH] eal: check cpu flags at init Flavio Leitner
2016-09-26 15:43 ` Aaron Conole
2016-09-27 18:32 ` Flavio Leitner
2016-09-29 20:42 ` Aaron Conole [this message]
2016-10-03 14:13 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7ttwcyv3ol.fsf@redhat.com \
--to=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=fbl@sysclose.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.