From: Aaron Conole <aconole@redhat.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
dev@openvswitch.org, davem@davemloft.net, kuba@kernel.org,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Pravin B Shelar <pshelar@ovn.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Florian Westphal <fw@strlen.de>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Ilya Maximets <i.maximets@ovn.org>
Subject: Re: [PATCHv2 net-next 5/5] net: extract nf_ct_handle_fragments to nf_conntrack_ovs
Date: Thu, 09 Feb 2023 10:08:28 -0500 [thread overview]
Message-ID: <f7tv8kag9lf.fsf@redhat.com> (raw)
In-Reply-To: <309974b4d45064b960003cca8b47dec66a0bb540.1675810210.git.lucien.xin@gmail.com> (Xin Long's message of "Tue, 7 Feb 2023 17:52:10 -0500")
Xin Long <lucien.xin@gmail.com> writes:
> Now handle_fragments() in OVS and TC have the similar code, and
> this patch removes the duplicate code by moving the function
> to nf_conntrack_ovs.
>
> Note that skb_clear_hash(skb) or skb->ignore_df = 1 should be
> done only when defrag returns 0, as it does in other places
> in kernel.
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
Reviewed-by: Aaron Conole <aconole@redhat.com>
next prev parent reply other threads:[~2023-02-09 15:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 22:52 [PATCHv2 net-next 0/5] net: move more duplicate code of ovs and tc conntrack into nf_conntrack_ovs Xin Long
2023-02-07 22:52 ` [PATCHv2 net-next 1/5] net: create nf_conntrack_ovs for ovs and tc use Xin Long
2023-02-08 10:15 ` Simon Horman
2023-02-09 14:59 ` Aaron Conole
2023-02-07 22:52 ` [PATCHv2 net-next 2/5] net: extract nf_ct_skb_network_trim function to nf_conntrack_ovs Xin Long
2023-02-08 10:15 ` Simon Horman
2023-02-09 15:00 ` Aaron Conole
2023-02-07 22:52 ` [PATCHv2 net-next 3/5] openvswitch: move key and ovs_cb update out of handle_fragments Xin Long
2023-02-08 10:16 ` Simon Horman
2023-02-09 15:01 ` Aaron Conole
2023-02-07 22:52 ` [PATCHv2 net-next 4/5] net: sched: move frag check and tc_skb_cb " Xin Long
2023-02-08 10:16 ` Simon Horman
2023-02-07 22:52 ` [PATCHv2 net-next 5/5] net: extract nf_ct_handle_fragments to nf_conntrack_ovs Xin Long
2023-02-08 10:17 ` Simon Horman
2023-02-09 15:08 ` Aaron Conole [this message]
2023-02-10 6:21 ` [PATCHv2 net-next 0/5] net: move more duplicate code of ovs and tc conntrack into nf_conntrack_ovs Jakub Kicinski
2023-02-10 10:35 ` Florian Westphal
2023-02-11 0:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7tv8kag9lf.fsf@redhat.com \
--to=aconole@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=i.maximets@ovn.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=pshelar@ovn.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.