From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Conole Subject: Re: [PATCH v7 02/14] eal: do not panic when CPU isn't supported Date: Thu, 23 Mar 2017 10:27:18 -0400 Message-ID: References: <20170322201940.24028-1-aconole@redhat.com> <20170322201940.24028-3-aconole@redhat.com> <20170323134730.GA8688@bricha3-MOBL3.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain Cc: dev@dpdk.org, Thomas Monjalon , Stephen Hemminger To: Bruce Richardson Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 8519FCF8A for ; Thu, 23 Mar 2017 15:27:19 +0100 (CET) In-Reply-To: <20170323134730.GA8688@bricha3-MOBL3.ger.corp.intel.com> (Bruce Richardson's message of "Thu, 23 Mar 2017 13:47:31 +0000") List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Bruce Richardson writes: > On Wed, Mar 22, 2017 at 04:19:28PM -0400, Aaron Conole wrote: >> This adds a new API to check for the eal cpu versions. >> >> It's now possible to gracefully exit the application, or for >> applications which support non-dpdk datapaths working in concert with >> DPDK datapaths, there no longer is the possibility of exiting for >> unsupported CPUs. >> >> Signed-off-by: Aaron Conole > > I think we should mark the old function as deprecated or else delete it > entirely. It was technically public, but I suspect it was only ever used > by the EAL init, so I'd look to get rid of it ASAP rather than leave it > hanging around unneeded. Okay, I'll submit a follow on patch after this is accepted to mark it as deprecated. I agree, I don't know of any application using it (though I looked at MoonGen, ovs, and warp17). > /Bruce