From: Aaron Conole <aconole@redhat.com>
To: Aleksei Oladko <aleksey.oladko@virtuozzo.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] selftests: net: make ovs-dpctl.py fail when pyroute2 is unsupported
Date: Thu, 22 Jan 2026 16:32:10 -0500 [thread overview]
Message-ID: <f7tzf65uyed.fsf@redhat.com> (raw)
In-Reply-To: <20260120230558.328423-3-aleksey.oladko@virtuozzo.com> (Aleksei Oladko's message of "Tue, 20 Jan 2026 23:05:55 +0000")
Hi Aleksei,
Aleksei Oladko <aleksey.oladko@virtuozzo.com> writes:
> The pmtu.sh kselftest configures OVS using ovs-dpctl.py and falls back
> to ovs-vsctl only when ovs-dpctl.py fails. However, ovs-dpctl.py exits
> with a success status when the installed pyroute2 package version is
> lower than 0.6, even though the OVS datapath is not configured.
>
> As a result, pmtu.sh assumes that the setup was successful and
> continues running the test, which later fails due to the missing
> OVS configuration.
>
> Fix the exit code handling in ovs-dpctl.py so that pmtu.sh can detect
> that the setup did not complete successfully and fall back to
> ovs-vsctl.
>
> Signed-off-by: Aleksei Oladko <aleksey.oladko@virtuozzo.com>
> ---
You should also include the fixes line when you post another version:
92e37f20f20a ("selftests: openvswitch: Add version check for pyroute2")
> tools/testing/selftests/net/openvswitch/ovs-dpctl.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/openvswitch/ovs-dpctl.py b/tools/testing/selftests/net/openvswitch/ovs-dpctl.py
> index b521e0dea506..848f61fdcee0 100644
> --- a/tools/testing/selftests/net/openvswitch/ovs-dpctl.py
> +++ b/tools/testing/selftests/net/openvswitch/ovs-dpctl.py
> @@ -2583,7 +2583,7 @@ def main(argv):
> prverscheck = pyroute2.__version__.split(".")
> if int(prverscheck[0]) == 0 and int(prverscheck[1]) < 6:
> print("Need to upgrade the python pyroute2 package to >= 0.6.")
> - sys.exit(0)
> + sys.exit(1)
>
> parser = argparse.ArgumentParser()
> parser.add_argument(
next prev parent reply other threads:[~2026-01-22 21:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 23:05 [PATCH 0/5] selftests: net: fix false failures due to missing features and host interference Aleksei Oladko
2026-01-20 23:05 ` [PATCH 1/5] selftests: net: fib_tests: skip rp_filter test if cls_basic is unavailable Aleksei Oladko
2026-01-20 23:05 ` [PATCH 2/5] selftests: net: make ovs-dpctl.py fail when pyroute2 is unsupported Aleksei Oladko
2026-01-22 21:32 ` Aaron Conole [this message]
2026-01-20 23:05 ` [PATCH 3/5] selftests: net: run reuseport tests in netns to avoid port conflicts Aleksei Oladko
2026-01-22 0:56 ` Jakub Kicinski
2026-01-20 23:05 ` [PATCH 4/5] selftests: net: run pmtu.sh in netns to avoid host firewall interference Aleksei Oladko
2026-01-20 23:05 ` [PATCH 5/5] selftests: net: io_uring_zerocopy: enable io_uring for the test Aleksei Oladko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7tzf65uyed.fsf@redhat.com \
--to=aconole@redhat.com \
--cc=aleksey.oladko@virtuozzo.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.