From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: References: <20180709132004.14468-1-tvrtko.ursulin@linux.intel.com> <20180709132004.14468-8-tvrtko.ursulin@linux.intel.com> From: John Harrison Message-ID: Date: Wed, 11 Jul 2018 23:38:54 -0700 MIME-Version: 1.0 In-Reply-To: <20180709132004.14468-8-tvrtko.ursulin@linux.intel.com> Content-Language: en-US Subject: Re: [igt-dev] [PATCH i-g-t 07/11] trace.pl: Fix engine busy accounting in split mode List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0286740371==" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Tvrtko Ursulin , igt-dev@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org, Tvrtko Ursulin List-ID: This is a multi-part message in MIME format. --===============0286740371== Content-Type: multipart/alternative; boundary="------------E7FA0824A4B923ED39F90064" Content-Language: en-US This is a multi-part message in MIME format. --------------E7FA0824A4B923ED39F90064 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 7/9/2018 6:20 AM, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > In split mode all requests have to be added up since they were previously > re-arranged so there is no overlap. > > Signed-off-by: Tvrtko Ursulin > Cc: John Harrison > --- > scripts/trace.pl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/scripts/trace.pl b/scripts/trace.pl > index 60a8e441c1d9..52372e224da5 100755 > --- a/scripts/trace.pl > +++ b/scripts/trace.pl > @@ -612,7 +612,8 @@ foreach my $key (@sorted_keys) { > $db{$key}->{'submit-delay'} = $db{$key}->{'submit'} - $db{$key}->{'queue'}; > $db{$key}->{'duration'} = $notify - $start; > > - $running{$ring} += $end - $start unless exists $db{$key}->{'no-end'}; > + $running{$ring} += $end - $start if $correct_durations or > + not exists $db{$key}->{'no-end'}; > $runnable{$ring} += $db{$key}->{'execute-delay'}; > $queued{$ring} += $start - $db{$key}->{'execute-delay'} - $db{$key}->{'queue'}; > Reviewed-by: John Harrison --------------E7FA0824A4B923ED39F90064 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit On 7/9/2018 6:20 AM, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

In split mode all requests have to be added up since they were previously
re-arranged so there is no overlap.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: John Harrison <John.C.Harrison@intel.com>
---
 scripts/trace.pl | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/trace.pl b/scripts/trace.pl
index 60a8e441c1d9..52372e224da5 100755
--- a/scripts/trace.pl
+++ b/scripts/trace.pl
@@ -612,7 +612,8 @@ foreach my $key (@sorted_keys) {
 	$db{$key}->{'submit-delay'} = $db{$key}->{'submit'} - $db{$key}->{'queue'};
 	$db{$key}->{'duration'} = $notify - $start;
 
-	$running{$ring} += $end - $start unless exists $db{$key}->{'no-end'};
+	$running{$ring} += $end - $start if $correct_durations or
+					    not exists $db{$key}->{'no-end'};
 	$runnable{$ring} += $db{$key}->{'execute-delay'};
 	$queued{$ring} += $start - $db{$key}->{'execute-delay'} - $db{$key}->{'queue'};

Reviewed-by: John Harrison <John.C.Harrison@Intel.com>

--------------E7FA0824A4B923ED39F90064-- --===============0286740371== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBt YWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2Cg== --===============0286740371==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Harrison Subject: Re: [PATCH i-g-t 07/11] trace.pl: Fix engine busy accounting in split mode Date: Wed, 11 Jul 2018 23:38:54 -0700 Message-ID: References: <20180709132004.14468-1-tvrtko.ursulin@linux.intel.com> <20180709132004.14468-8-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1358154705==" Return-path: In-Reply-To: <20180709132004.14468-8-tvrtko.ursulin@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , igt-dev@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org This is a multi-part message in MIME format. --===============1358154705== Content-Type: multipart/alternative; boundary="------------E7FA0824A4B923ED39F90064" Content-Language: en-US This is a multi-part message in MIME format. --------------E7FA0824A4B923ED39F90064 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 7/9/2018 6:20 AM, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > In split mode all requests have to be added up since they were previously > re-arranged so there is no overlap. > > Signed-off-by: Tvrtko Ursulin > Cc: John Harrison > --- > scripts/trace.pl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/scripts/trace.pl b/scripts/trace.pl > index 60a8e441c1d9..52372e224da5 100755 > --- a/scripts/trace.pl > +++ b/scripts/trace.pl > @@ -612,7 +612,8 @@ foreach my $key (@sorted_keys) { > $db{$key}->{'submit-delay'} = $db{$key}->{'submit'} - $db{$key}->{'queue'}; > $db{$key}->{'duration'} = $notify - $start; > > - $running{$ring} += $end - $start unless exists $db{$key}->{'no-end'}; > + $running{$ring} += $end - $start if $correct_durations or > + not exists $db{$key}->{'no-end'}; > $runnable{$ring} += $db{$key}->{'execute-delay'}; > $queued{$ring} += $start - $db{$key}->{'execute-delay'} - $db{$key}->{'queue'}; > Reviewed-by: John Harrison --------------E7FA0824A4B923ED39F90064 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit On 7/9/2018 6:20 AM, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

In split mode all requests have to be added up since they were previously
re-arranged so there is no overlap.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: John Harrison <John.C.Harrison@intel.com>
---
 scripts/trace.pl | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/trace.pl b/scripts/trace.pl
index 60a8e441c1d9..52372e224da5 100755
--- a/scripts/trace.pl
+++ b/scripts/trace.pl
@@ -612,7 +612,8 @@ foreach my $key (@sorted_keys) {
 	$db{$key}->{'submit-delay'} = $db{$key}->{'submit'} - $db{$key}->{'queue'};
 	$db{$key}->{'duration'} = $notify - $start;
 
-	$running{$ring} += $end - $start unless exists $db{$key}->{'no-end'};
+	$running{$ring} += $end - $start if $correct_durations or
+					    not exists $db{$key}->{'no-end'};
 	$runnable{$ring} += $db{$key}->{'execute-delay'};
 	$queued{$ring} += $start - $db{$key}->{'execute-delay'} - $db{$key}->{'queue'};

Reviewed-by: John Harrison <John.C.Harrison@Intel.com>

--------------E7FA0824A4B923ED39F90064-- --===============1358154705== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============1358154705==--