From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 3/3] drm/i915: properly cancel rps_work on module unload v2 Date: Thu, 08 Sep 2011 21:51:30 +0100 Message-ID: References: <1315483222-2195-1-git-send-email-daniel.vetter@ffwll.ch> <1315483222-2195-3-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 657229F577 for ; Thu, 8 Sep 2011 13:51:33 -0700 (PDT) In-Reply-To: <1315483222-2195-3-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Daniel Vetter , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Thu, 8 Sep 2011 14:00:22 +0200, Daniel Vetter wrote: > The rps disabling code wasn't properly cancelling outstanding work > items. Also add a comment that explains why we're not racing with > the work item that could unmask interrupts - that piece of code > confused me quite a bit. > > v2: Ben Widawsky pointed out that the first patch would deadlock > (and a few lesser problems). All corrected. > > Signed-off-by: Daniel Vetter > Reviewed-by: Ben Widawsky And since presumably the chip is in a completely different thermal envelope and thawed, waking up the task function is pointless after resume. ;-) With the original deadlocks gone, Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre