From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 09/16] drm/i915/gmbus: Reset the controller on initialisation Date: Fri, 13 May 2011 10:32:25 +0100 Message-ID: References: <1305235044-9159-1-git-send-email-chris@chris-wilson.co.uk> <1305235044-9159-10-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 4154D9E7A4 for ; Fri, 13 May 2011 02:32:28 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Keith Packard Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 12 May 2011 17:41:36 -0700, Keith Packard wrote: > On Thu, 12 May 2011 22:17:17 +0100, Chris Wilson wrote: > > > Toggle the Software Clear Interrupt bit which resets the controller to > > clear any prior BUS_ERROR condition before we begin to use the > > controller in earnest. > > Looks reasonable, except for the bad register offsets (see reply to > previous patch). I fear this code wasn't tested at all; it shouldn't > have worked. It has been booting daily on several machines for a month. I agree it wouldn't have worked, but the since we automatically fallback to GPIO should it go south, the failures didn't stop the external monitors from being lit up. -Chris -- Chris Wilson, Intel Open Source Technology Centre