From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 14/16] drm/i915: Use PCI-ID to identify Broadwater and Crestline Date: Fri, 13 May 2011 10:39:13 +0100 Message-ID: References: <1305235044-9159-1-git-send-email-chris@chris-wilson.co.uk> <1305235044-9159-15-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 731539E7A4 for ; Fri, 13 May 2011 02:39:16 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Keith Packard Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 12 May 2011 18:16:00 -0700, Keith Packard wrote: > On Thu, 12 May 2011 22:17:22 +0100, Chris Wilson wrote: > > > ... as they only had a single PCI-ID each, and so using the pci-id is > > easier than using a capability bit. > > This doesn't seem useful to me; it only saves a couple of bits in the > struct and replaces that with compares. Meh. The switch is from a comparatively expensive compare to a cheaper compare *consistent* with the other individual chipset identifiers. -Chris -- Chris Wilson, Intel Open Source Technology Centre