From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 1/3] drm/i915: extract constant offset
	setting
Date: Tue, 11 Oct 2011 20:09:12 +0100
Message-ID: <f80fcd$253nr6@fmsmga001.fm.intel.com>
References: <1318357916-12661-1-git-send-email-ben@bwidawsk.net>
	<1318357916-12661-2-git-send-email-ben@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
	by gabe.freedesktop.org (Postfix) with ESMTP id 327009E755
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 11 Oct 2011 12:09:15 -0700 (PDT)
In-Reply-To: <1318357916-12661-2-git-send-email-ben@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: intel-gfx@lists.freedesktop.org
Cc: Ben Widawsky <ben@bwidawsk.net>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, 11 Oct 2011 11:31:54 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>

Nice clean up. Reveals we have a bug if the reservation is interrupted
though. The actual loading of the register should be delayed until we
are about to dispatch the execbuffer (and so won't be interferred by any
usurper.)
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre