From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/3] drm/i915: make eb structure do more Date: Tue, 11 Oct 2011 20:11:56 +0100 Message-ID: References: <1318357916-12661-1-git-send-email-ben@bwidawsk.net> <1318357916-12661-3-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id A25D2A099D for ; Tue, 11 Oct 2011 12:11:58 -0700 (PDT) In-Reply-To: <1318357916-12661-3-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Tue, 11 Oct 2011 11:31:55 -0700, Ben Widawsky wrote: > clean up some code using the existing eb structure. > > There is a tiny hunk here related to setting eb->cliprects which is not > really useful yet, but will be in the future. You're scaring me! In the current incarnation there is no way cliprects can be used successfully as it interferes with the 3D setup that the batch believes itself to be in full control over... Is there something fun in the pipeline? ;-) > Signed-off-by: Ben Widawsky Other than the obnoxious cliprects, Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre