From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/6] drm/i915: hangcheck robustification
Date: Wed, 19 Oct 2011 16:48:17 +0100 [thread overview]
Message-ID: <f80fcd$27v13q@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <20111019080257.2d1828b0@bwidawsk.net>
On Wed, 19 Oct 2011 08:02:57 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> On Wed, 19 Oct 2011 12:32:25 +0100
> Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > NAK: This failed to detect a hang, leaving my box frozen. I suspect that
> > the value of INSTDONE was fluctuating on the render ring even though we
> > had now requests pending and so could assume that it was idle.
> > -Chris
> >
> How is that different than the previous behavior? We checked instdone on
> the render ring before this patch too.
As mentioned on irc, that is probably a wild goose chase. This is the
first false negative I have observed with hangcheck, so I blame the
robustification patch (as being a self-grandeous patch ;-). A false
negative has much worse consequences than a false positive - so we need
to be sure we can avoid such at any cost.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2011-10-19 15:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 14:39 [PATCH 1/6] drm/i915: hangcheck robustification Daniel Vetter
2011-10-11 14:39 ` [PATCH 2/6] drm/i915: kicking rings stuck on semaphores considered harmful Daniel Vetter
2011-10-11 15:51 ` Chris Wilson
2011-10-11 20:48 ` Ben Widawsky
2011-10-11 14:39 ` [PATCH 3/6] drm/i915: don't bail out of intel_wait_ring_buffer too early Daniel Vetter
2011-10-11 15:53 ` Chris Wilson
2011-10-11 17:25 ` [PATCH] " Daniel Vetter
2011-10-18 15:24 ` Chris Wilson
2011-10-11 14:39 ` [PATCH 4/6] drm/i915: switch ring->id to be a real id Daniel Vetter
2011-10-11 15:55 ` Chris Wilson
2011-10-11 17:27 ` [PATCH] drm/i915: don't bail out of intel_wait_ring_buffer too early Daniel Vetter
2011-10-11 19:31 ` Daniel Vetter
2011-10-11 17:29 ` [PATCH] drm/i915: switch ring->id to be a real id Daniel Vetter
2011-10-18 15:27 ` Chris Wilson
2011-10-11 14:39 ` [PATCH 5/6] drm/i915: refactor ring error state capture to use arrays Daniel Vetter
2011-10-11 15:57 ` Chris Wilson
2011-10-11 14:39 ` [PATCH 6/6] drm/i915: collect more per ring error state Daniel Vetter
2011-10-11 16:01 ` Chris Wilson
2011-10-11 17:30 ` [PATCH] " Daniel Vetter
2011-10-11 19:23 ` Chris Wilson
2011-10-11 19:20 ` Daniel Vetter
2011-10-30 18:39 ` Chris Wilson
2011-10-30 18:46 ` Chris Wilson
2011-10-19 11:32 ` [PATCH 1/6] drm/i915: hangcheck robustification Chris Wilson
2011-10-19 15:02 ` Ben Widawsky
2011-10-19 15:48 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='f80fcd$27v13q@fmsmga001.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=ben@bwidawsk.net \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.