From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jesse Barnes <jbarnes@virtuousgeek.org>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 04/12] drm: remove unused save/restore fields from drm_connector & fix comments
Date: Mon, 07 Nov 2011 20:26:59 +0000 [thread overview]
Message-ID: <f80fcd$2e9s5b@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <1320696203-5524-5-git-send-email-jbarnes@virtuousgeek.org>
On Mon, 7 Nov 2011 12:03:15 -0800, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> Also fix up the wrapping to 80 columns.
>
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---
> include/drm/drm_crtc.h | 20 +++++++-------------
> 1 files changed, 7 insertions(+), 13 deletions(-)
>
> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
> index ad2a605..6ab20f8 100644
> --- a/include/drm/drm_crtc.h
> +++ b/include/drm/drm_crtc.h
> @@ -386,26 +386,19 @@ struct drm_crtc {
> /**
> * drm_connector_funcs - control connectors on a given device
> * @dpms: set power state (see drm_crtc_funcs above)
> - * @save: save connector state
> - * @restore: restore connector state
> * @reset: reset connector after state has been invalidate (e.g. resume)
> - * @mode_valid: is this mode valid on the given connector?
> - * @mode_fixup: try to fixup proposed mode for this connector
> - * @mode_set: set this mode
> * @detect: is this connector active?
> - * @get_modes: get mode list for this connector
> + * @fill_modes: build a mode list for this connector
> * @set_property: property for this connector may need update
> * @destroy: make object go away
> * @force: notify the driver the connector is forced on
> *
> * Each CRTC may have one or more connectors attached to it. The functions
> - * below allow the core DRM code to control connectors, enumerate available modes,
> - * etc.
> + * below allow the core DRM code to control connectors, enumerate available
> + * modes, etc.
> */
> struct drm_connector_funcs {
> void (*dpms)(struct drm_connector *connector, int mode);
> - void (*save)(struct drm_connector *connector);
> - void (*restore)(struct drm_connector *connector);
> void (*reset)(struct drm_connector *connector);
>
> /* Check to see if anything is attached to the connector.
> @@ -416,9 +409,10 @@ struct drm_connector_funcs {
> */
> enum drm_connector_status (*detect)(struct drm_connector *connector,
> bool force);
> - int (*fill_modes)(struct drm_connector *connector, uint32_t max_width, uint32_t max_height);
> - int (*set_property)(struct drm_connector *connector, struct drm_property *property,
> - uint64_t val);
> + int (*fill_modes)(struct drm_connector *connector, uint32_t max_width,
> + uint32_t max_height);
Attack of the random 80-column limit!
int (*fill_modes)(struct drm_connector *connector,
uint32_t max_width, uint32_t max_height);
keeps the logically more connected width&height together.
What colour do you want your bikeshed today?
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-11-07 20:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 20:03 Misc. cleanups Jesse Barnes
2011-11-07 20:03 ` [PATCH 01/12] drm: remove unused connector_count field from drm_display_mode Jesse Barnes
2011-11-07 20:03 ` [PATCH 02/12] drm: remove unused save/restore functions from drm_crtc_funcs & fix comments Jesse Barnes
2011-11-07 20:03 ` [PATCH 03/12] drm: fix comments for drm_crtc struct Jesse Barnes
2011-11-07 20:03 ` [PATCH 04/12] drm: remove unused save/restore fields from drm_connector & fix comments Jesse Barnes
2011-11-07 20:26 ` Chris Wilson [this message]
2011-11-07 20:35 ` Jesse Barnes
2011-11-07 20:03 ` [PATCH 05/12] drm: add comments for drm_encoder_funcs Jesse Barnes
2011-11-07 20:03 ` [PATCH 06/12] drm: add drm_encoder comments Jesse Barnes
2011-11-07 20:03 ` [PATCH 07/12] drm: remove unused fields in drm_connector and document the rest Jesse Barnes
2011-11-07 20:03 ` [PATCH 08/12] drm: document drm_mode_set structure Jesse Barnes
2011-11-07 20:03 ` [PATCH 09/12] drm: document and cleanup drm_mode_config_funcs Jesse Barnes
2011-11-07 20:03 ` [PATCH 10/12] drm: document the drm_mode_group structure Jesse Barnes
2011-11-07 20:03 ` [PATCH 11/12] drm: document the drm_mode_config structure Jesse Barnes
2011-11-07 20:03 ` [PATCH 12/12] drm: remove some potentially dangerous DRM_ERRORs Jesse Barnes
2011-11-07 20:27 ` Misc. cleanups Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='f80fcd$2e9s5b@fmsmga001.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.