From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 16/43] drm/i915: rework dev->first_error locking Date: Wed, 14 Dec 2011 15:13:16 +0000 Message-ID: References: <1323867460-5486-1-git-send-email-daniel.vetter@ffwll.ch> <1323867460-5486-16-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id CF4AC9E7BB for ; Wed, 14 Dec 2011 07:13:40 -0800 (PST) In-Reply-To: <1323867460-5486-16-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Keith Packard Cc: Daniel Vetter , intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Wed, 14 Dec 2011 13:57:13 +0100, Daniel Vetter wrote: > - reduce the irq disabled section, even for a debugfs file this was > way too long. > - always disable irqs when taking the lock. > > v2: Thou shalt not mistake locking for reference counting, so: > - reference count the error_state to protect from concurent freeeing. > This will be only really used in the next patch. > > Signed-Off-by: Daniel Vetter Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre