From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 3/3] drm/i915: Adding 1080p modes to our TV Out mode list. Date: Thu, 15 Dec 2011 16:06:47 +0000 Message-ID: References: <1323904208-5427-1-git-send-email-rodrigo.vivi@gmail.com> <1323904208-5427-4-git-send-email-rodrigo.vivi@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 93A649E84B for ; Thu, 15 Dec 2011 08:07:08 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 15 Dec 2011 13:05:24 -0200, Rodrigo Vivi wrote: > sorry... last email was unfinished and it was sent by mistake.. full version: > > For other patches in this serie the table can be found at our PRM > http://intellinuxgraphics.org/VOL_3_display_registers_updated.pdf > > Section 5.2 TV Out Programming / 5.2.1 Television Standards / 5.2.1.1 > Timing Table > > However the 1080p was added on the new version witch is internal for now. > I'm going to change the commit comment but I'm not happy with the > comment such as: > > "Adding 1080p supported modes according to new PRM version which is > internal for now." > > Because in a near future this document will be public and the comment > will be there forever. The comment can be updated to match the public material once it becomes available (and more likely when someone finds something that needs changing). If someone finds a reference to an internal document, they are likely to ask us for it. At that point, we can double check whether the material is now public, answer their question for them (and see if we can improve the code so that the question becomes unncessary) or see if we can provide them with the document under NDA. Without a reference at all, that dialogue will never happen and we run the risk of loosing the review. And more likely we will forget where to find the information and have to search all the specs afresh. I'll trade confusing a few people for saving time and preventing mistakes later. -Chris -- Chris Wilson, Intel Open Source Technology Centre