From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 20/20] drm: do not set fb_info->pixmap fields Date: Wed, 01 Feb 2012 12:00:11 +0000 Message-ID: References: <1328092718-28951-1-git-send-email-s.hauer@pengutronix.de> <1328092718-28951-21-git-send-email-s.hauer@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id E5983A0B2E for ; Wed, 1 Feb 2012 04:00:16 -0800 (PST) In-Reply-To: <1328092718-28951-21-git-send-email-s.hauer@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Sascha Hauer , dri-devel@lists.freedesktop.org Cc: kernel@pengutronix.de List-Id: dri-devel@lists.freedesktop.org On Wed, 1 Feb 2012 11:38:38 +0100, Sascha Hauer wrote: > The drm drivers set the fb_info->pixmap fields without setting > fb_info->pixmap.addr. If this is not set the fb core will overwrite > these all fb_info->pixmap fields anyway, so there is not much point > in setting them in the first place. Might be worth replacing those blocks with a comment: /* Use default scratch pixmap (info->pixmap.flags = FB_PIXMAP_SYSTEM) */ -Chris -- Chris Wilson, Intel Open Source Technology Centre