From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Suppress warning for MTRR failure if PAT is enabled Date: Mon, 20 Feb 2012 20:51:50 +0000 Message-ID: References: <1329765603-6800-1-git-send-email-chris@chris-wilson.co.uk> <87boot5k88.fsf@eliezer.anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id CAD17A0AAA for ; Mon, 20 Feb 2012 12:51:55 -0800 (PST) In-Reply-To: <87boot5k88.fsf@eliezer.anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Eric Anholt , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 20 Feb 2012 12:21:43 -0800, Eric Anholt wrote: > Now that PAT has been reliable without MTRRs in place for a while, I > agree with the patch (but not with removing the braces around the > multi-line printf). I thought the braces around the single line was a checkpatch violation. Having run the revert through checkpatch.pl, turns out I was wrong. -Chris -- Chris Wilson, Intel Open Source Technology Centre