From: Chris Wilson <chris@chris-wilson.co.uk>
To: Eugeni Dodonov <eugeni@dodonov.net>,
Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: RFC: i915 arch changes to better support new chipsets
Date: Wed, 21 Mar 2012 11:58:15 +0000 [thread overview]
Message-ID: <f80fcd$3tbn72@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <CAC7LmnvGMqNmwC+6+rdTPbR53U-a_7LfVPZ9KA3g+8PVTVgt2Q@mail.gmail.com>
On Wed, 21 Mar 2012 08:42:37 -0300, Eugeni Dodonov <eugeni@dodonov.net> wrote:
> I was also thinking on adding a intel_workarounds.c for handling all the
> W/As we have in one place, and having some support for calling them via
> callbacks to run specific WAs during the modeset, after suspend/resume
> cycle and so on.
Too much midlayer. The recipe for modesetting for a particular chipset
goes in e.g. intel_display_pch_ibx.c and that recipe includes the w/a
with the calls to common code in intel_display_pch.c and beyond. (It
should ideally be a straight lift out of the bspec of the modesetting
sequence.) Not the other way around. Otherwise you just have the same
tangle of code just split over many different files and the coupling
masked through complex assemblages of vtables.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-03-21 11:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 18:13 RFC: i915 arch changes to better support new chipsets Jesse Barnes
2012-03-20 18:43 ` Daniel Vetter
2012-03-20 20:13 ` Jesse Barnes
2012-03-21 11:42 ` Eugeni Dodonov
2012-03-21 11:58 ` Chris Wilson [this message]
2012-03-21 20:41 ` Jesse Barnes
2012-03-28 19:35 ` Eric Anholt
2012-03-28 19:46 ` Jesse Barnes
2012-03-28 19:59 ` Eugeni Dodonov
2012-03-28 20:29 ` Eric Anholt
2012-03-28 20:37 ` Daniel Vetter
2012-03-29 1:02 ` Eugeni Dodonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='f80fcd$3tbn72@fmsmga001.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=eugeni@dodonov.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.