From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/2] drm/i915: Remove fence pipelining infrastructure Date: Fri, 23 Mar 2012 20:13:47 +0000 Message-ID: References: <1332429001-13725-1-git-send-email-chris@chris-wilson.co.uk> <1332429001-13725-2-git-send-email-chris@chris-wilson.co.uk> <20120323191837.GH4087@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 82E909E8D8 for ; Fri, 23 Mar 2012 13:14:20 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 23 Mar 2012 20:02:05 +0000, Chris Wilson wrote: > On Fri, 23 Mar 2012 20:18:37 +0100, Daniel Vetter wrote: > > Mea culpa, but I agree that it's better to reap this instead of letting it > > languish even longer as some dead code. For the patch itself, this does > > way too much. Imo the gem_write_fence rework and the reaping of the > > pipelining logic should be separate patches (maybe even more) - I don't > > quite see through this patch and follow where things move to. > > I got bored of rewriting the same 200 lines with the incremental churn. > Every patch only made sense as "preparing to rip out pipelining". Meant to add: but since it is you, I'll give it another shot. -Chris -- Chris Wilson, Intel Open Source Technology Centre