From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 1/2] drm/i915/sdov: switch IS_SDVOB to a flag Date: Fri, 23 Mar 2012 22:59:14 +0000 Message-ID: References: <1332542616-2367-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 958B89F2FD for ; Fri, 23 Mar 2012 15:59:20 -0700 (PDT) In-Reply-To: <1332542616-2367-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Fri, 23 Mar 2012 23:43:35 +0100, Daniel Vetter wrote: > With valleyview we'll have these at yet another address, so keeping > track of this with an ever-growing list of registers will get ugly. > > This way intel_sdvo.c is fully independent of the base address of the > output ports display register blocks. > > While at it, do 2 closely related cleanups: > - use SDVO_NAME some more > - change the sdvo_reg variables to uint32_t like other registers. > > Signed-Off-by: Daniel Vetter Not much to say, removing the duplication of SDVO_NAME is nice. Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre