From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: use BLT ring for flips on IVB Date: Mon, 13 Jun 2011 23:22:08 +0100 Message-ID: References: <1307646877-1979-1-git-send-email-jbarnes@virtuousgeek.org> <4DF70A43.4040804@whitecape.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id C405C9E794 for ; Mon, 13 Jun 2011 15:22:20 -0700 (PDT) In-Reply-To: <4DF70A43.4040804@whitecape.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Kenneth Graunke , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 14 Jun 2011 00:14:11 -0700, Kenneth Graunke wrote: > On 06/09/2011 12:14 PM, Jesse Barnes wrote: > > Found a couple more problems: > > 1) MI_DISPLAY_FLIP should take a '1' in the last byte to indicate > > length on IVB > > 2) apprently only the BLT ring version of the command actually causes > > interrupts to be generated > > > > With this patch, modetest -v works on my test platform. Clearly it's in > > need of more splitting though. The case statement should be split into > > per-chipset flip command generation. > > > > Signed-off-by: Jesse Barnes > > Reviewed-and-tested-by: Kenneth Graunke But it's not the neatest patch in the world ;-) Using struct intel_ring_buffer *ring for all generation and switching between blt/render on demand should be neater. Also we should be able to do pageflips from either the render or blt ring on gen7, right? That will be useful to avoid a synchronisation point. -Chris -- Chris Wilson, Intel Open Source Technology Centre