From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: Revert "drm/i915: Enable GMBUS for post-gen2 chipsets" Date: Thu, 16 Jun 2011 21:21:01 +0100 Message-ID: References: <20110604213456.7ac5588e@endymion.delvare> <20110611132815.52d887bb@schatten.dmk.lab> <20110611145849.5f9b7944@endymion.delvare> <20110616221107.045a142d@endymion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 3E7159E759 for ; Thu, 16 Jun 2011 13:21:18 -0700 (PDT) In-Reply-To: <20110616221107.045a142d@endymion.delvare> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Jean Delvare , Dave Airlie Cc: Andrew Morton , Florian Mickler , luto@mit.edu, markotahal@gmail.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Thu, 16 Jun 2011 22:11:07 +0200, Jean Delvare wrote: > Hi Dave, > > On Tue, 14 Jun 2011 13:39:35 +1000, Dave Airlie wrote: > > Chris, also I don't see an ack anywhere on the list, only some > > discussion in the bug, > > I would indeed love to get a ack from Chris. Sure, let me ack it again. Hmm, was the last ack on linux-kernel, not dri-devel? > > I suspect the correct fix is to remove all the offending code instead > > of just putting back the piece > > of plaster that fell out of the wall. > > Which "offending code" are you talking about? Dave and myself chatted on irc and hopefully we cleared up the confusion that this patch is indeed just restoring the code to 2.6.39. And that further works needs to be done before trying GMBUS again. -Chris -- Chris Wilson, Intel Open Source Technology Centre