From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 5/6] drm/i915: Delete a misleading comment Date: Thu, 16 Jun 2011 21:53:32 +0100 Message-ID: References: <1308256588-8026-1-git-send-email-ajax@redhat.com> <1308256588-8026-5-git-send-email-ajax@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 745559E759 for ; Thu, 16 Jun 2011 13:53:35 -0700 (PDT) In-Reply-To: <1308256588-8026-5-git-send-email-ajax@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Adam Jackson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 16 Jun 2011 16:36:27 -0400, Adam Jackson wrote: > It's not wrong, but the text and the code describe different predicates > and my brain kept stumbling over it. > > Signed-off-by: Adam Jackson > --- > drivers/gpu/drm/i915/intel_sdvo.c | 5 +---- > 1 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c > index 193919e..c2272f7 100644 > --- a/drivers/gpu/drm/i915/intel_sdvo.c > +++ b/drivers/gpu/drm/i915/intel_sdvo.c > @@ -1320,10 +1320,7 @@ intel_sdvo_tmds_sink_detect(struct drm_connector *connector) > if (edid) > break; > } > - /* > - * If we found the EDID on the other bus, > - * assume that is the correct DDC bus. > - */ > + How about? If we foudn the EDID on another bus, presume that is the correct DDC bus and keep using that bus for future queries. Otherwise, restore the original value. > if (edid == NULL) > intel_sdvo->ddc_bus = saved_ddc; > } -- Chris Wilson, Intel Open Source Technology Centre