From: Thomas De Schampheleire <patrickdepinguin@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1 of 2 v3] infra/pkg-kconfig: join comments to the related code-block
Date: Tue, 05 Aug 2014 12:36:52 +0200 [thread overview]
Message-ID: <f81734945d5b08517be7.1407235012@localhost> (raw)
In-Reply-To: <patchbomb.1407235011@localhost>
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
The current layout of comments wrt. to the related code-blocks is a bit
hard to handle visually.
Remove empty lines between the comments and their respective related
code-blocks.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Acked-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
---
v3: no changes
package/pkg-kconfig.mk | 7 -------
1 file changed, 7 deletions(-)
diff -r df91fcff2e1a -r f81734945d5b package/pkg-kconfig.mk
--- a/package/pkg-kconfig.mk Wed Apr 30 16:21:53 2014 +0200
+++ b/package/pkg-kconfig.mk Tue Aug 05 00:06:57 2014 +0200
@@ -32,36 +32,30 @@
$(call inner-generic-package,$(1),$(2),$(3),$(4))
# Default values
-
$(2)_KCONFIG_EDITORS ?= menuconfig
$(2)_KCONFIG_OPT ?=
$(2)_KCONFIG_FIXUP_CMDS ?=
# FOO_KCONFIG_FILE is required
-
ifndef $(2)_KCONFIG_FILE
$$(error Internal error: no value specified for $(2)_KCONFIG_FILE)
endif
# The .config file is obtained by copying it from the specified source
# configuration file, after the package has been patched.
-
$$($(2)_DIR)/.config: $$($(2)_KCONFIG_FILE) | $(1)-patch
$$(INSTALL) -m 0644 $$($(2)_KCONFIG_FILE) $$($(2)_DIR)/.config
# In order to get a usable, consistent configuration, some fixup may be needed.
# The exact rules are specified by the package .mk file.
-
$$($(2)_DIR)/.stamp_kconfig_fixup_done: $$($(2)_DIR)/.config
$$($(2)_KCONFIG_FIXUP_CMDS)
$$(Q)touch $$@
# Before running configure, the configuration file should be present and fixed
-
$$($(2)_TARGET_CONFIGURE): $$($(2)_DIR)/.stamp_kconfig_fixup_done
# Configuration editors (menuconfig, ...)
-
$$(addprefix $(1)-,$$($(2)_KCONFIG_EDITORS)): $$($(2)_DIR)/.stamp_kconfig_fixup_done
$$($(2)_MAKE_ENV) $$(MAKE) -C $$($(2)_DIR) \
$$($(2)_KCONFIG_OPT) $$(subst $(1)-,,$$@)
@@ -69,7 +63,6 @@
rm -f $$($(2)_DIR)/.stamp_{target,staging}_installed
# Target to copy back the configuration to the source configuration file
-
$(1)-update-config: $$($(2)_DIR)/.stamp_kconfig_fixup_done
cp -f $$($(2)_DIR)/.config $$($(2)_KCONFIG_FILE)
next prev parent reply other threads:[~2014-08-05 10:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 10:36 [Buildroot] [PATCH 0 of 2 v3] Fix pkg-kconfig infra Thomas De Schampheleire
2014-08-05 10:36 ` Thomas De Schampheleire [this message]
2014-08-05 10:36 ` [Buildroot] [PATCH 2 of 2 v3] infra/pkg-kconfig: incorporate oldconfig call to avoid endless rebuilds Thomas De Schampheleire
2014-08-05 19:27 ` Yann E. MORIN
2014-08-05 19:37 ` Thomas De Schampheleire
2014-08-06 17:58 ` [Buildroot] [PATCH 0 of 2 v3] Fix pkg-kconfig infra Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f81734945d5b08517be7.1407235012@localhost \
--to=patrickdepinguin@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.