Re: [PATCH]Panasonic Hotkey Driver

[vgod spam <vgod.spam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

Hi,
I found a little problem in your driver(ver 0.5)...

> result = acpi_bus_register_driver(&acpi_hotkey_driver);
> if (ACPI_FAILURE(result)) {
>             ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Error registering hotkey driver\n"));
>             return_VALUE(-ENODEV);
>}
The return value of acpi_bus_register_driver is the number of devices
that were claimed by the driver, or a negative error status for
failure. But ACPI_FAILURE is a macro for checking whether the value is
zero or not. I think using "if ( result < 0 ) {.." here is better.

BTW, I have wrote a user space hotkey handler in Perl, which supported
LCD brightness adjustment now:)
It is available at http://vgod.info/dl/w2d/hotkey


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285