From: Maximilian Luz <luzmaximilian@gmail.com>
To: Johan Hovold <johan+linaro@kernel.org>,
Bjorn Andersson <andersson@kernel.org>
Cc: Konrad Dybcio <konradybcio@kernel.org>,
Elliot Berman <quic_eberman@quicinc.com>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] firmware: qcom: uefisecapp: fix efivars registration race
Date: Sat, 25 Jan 2025 17:32:15 +0100 [thread overview]
Message-ID: <f838ff5d-a80c-413b-b32b-766ec4667892@gmail.com> (raw)
In-Reply-To: <20250120151000.13870-1-johan+linaro@kernel.org>
On 1/20/25 4:10 PM, Johan Hovold wrote:
> Since the conversion to using the TZ allocator, the efivars service is
> registered before the memory pool has been allocated, something which
> can lead to a NULL-pointer dereference in case of a racing EFI variable
> access.
>
> Make sure that all resources have been set up before registering the
> efivars.
>
> Fixes: 6612103ec35a ("firmware: qcom: qseecom: convert to using the TZ allocator")
> Cc: stable@vger.kernel.org # 6.11
> Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
Looks good to me.
Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>
next prev parent reply other threads:[~2025-01-25 16:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-20 15:10 [PATCH] firmware: qcom: uefisecapp: fix efivars registration race Johan Hovold
2025-01-23 12:10 ` Konrad Dybcio
2025-01-25 16:32 ` Maximilian Luz [this message]
2025-01-27 15:46 ` Bartosz Golaszewski
2025-02-14 22:38 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f838ff5d-a80c-413b-b32b-766ec4667892@gmail.com \
--to=luzmaximilian@gmail.com \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_eberman@quicinc.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.