From: Jacob Keller <jacob.e.keller@intel.com>
To: <hsimeliere.opensource@witekio.com>, <stable@vger.kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
"Jose Abreu" <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
<netdev@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH stmmac 4.19 1/2] stmmac: no need to check return value of debugfs_create functions
Date: Fri, 16 Feb 2024 14:34:11 -0800 [thread overview]
Message-ID: <f858dfa8-478e-4537-a8c5-2c16603587ee@intel.com> (raw)
In-Reply-To: <20240215151527.6098-2-hsimeliere.opensource@witekio.com>
On 2/15/2024 7:15 AM, hsimeliere.opensource@witekio.com wrote:
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> [ Upstream commit 8d72ab119f42f25abb393093472ae0ca275088b6 ]
>
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Because we don't care about the individual files, we can remove the
> stored dentry for the files, as they are not needed to be kept track of
> at all.
>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: Jose Abreu <joabreu@synopsys.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: netdev@vger.kernel.org
> Cc: linux-stm32@st-md-mailman.stormreply.com
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> Signed-off-by: Hugo SIMELIERE <hsimeliere.opensource@witekio.com>
> ---
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
next prev parent reply other threads:[~2024-02-16 22:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 15:15 [PATCH stmmac 4.19 0/2] Fix kernel freeze when probing stmmac devices hsimeliere.opensource
2024-02-15 15:15 ` [PATCH stmmac 4.19 1/2] stmmac: no need to check return value of debugfs_create functions hsimeliere.opensource
2024-02-16 22:34 ` Jacob Keller [this message]
2024-02-15 15:15 ` [PATCH stmmac 4.19 2/2] net: stmmac: fix notifier registration hsimeliere.opensource
2024-02-23 13:14 ` [PATCH stmmac 4.19 0/2] Fix kernel freeze when probing stmmac devices Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f858dfa8-478e-4537-a8c5-2c16603587ee@intel.com \
--to=jacob.e.keller@intel.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=hsimeliere.opensource@witekio.com \
--cc=joabreu@synopsys.com \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.