From: Javier Martinez Canillas <javierm@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
daniel@ffwll.ch, deller@gmx.de, m.szyprowski@samsung.com,
geert@linux-m68k.org, sam@ravnborg.org
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] fbdev: Fix sys_imageblit() for arbitrary image widths
Date: Thu, 17 Mar 2022 12:20:50 +0100 [thread overview]
Message-ID: <f867cce1-04dd-a87a-700d-343cc28f188f@redhat.com> (raw)
In-Reply-To: <20220313192952.12058-2-tzimmermann@suse.de>
Hello Thomas,
On 3/13/22 20:29, Thomas Zimmermann wrote:
> Commit 6f29e04938bf ("fbdev: Improve performance of sys_imageblit()")
> broke sys_imageblit() for image width that are not aligned to 8-bit
> boundaries. Fix this by handling the trailing pixels on each line
> separately. The performance improvements in the original commit do not
> regress by this change.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Fixes: 6f29e04938bf ("fbdev: Improve performance of sys_imageblit()")
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Javier Martinez Canillas <javierm@redhat.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> ---
Looks good to me. Also Marek and Geert mentioned that fixes the issue
they were seeing.
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
next prev parent reply other threads:[~2022-03-17 11:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-13 19:29 [PATCH 0/2] fbdev: Fix image blitting for arbitrary image widths Thomas Zimmermann
2022-03-13 19:29 ` Thomas Zimmermann
2022-03-13 19:29 ` [PATCH 1/2] fbdev: Fix sys_imageblit() " Thomas Zimmermann
2022-03-13 19:29 ` Thomas Zimmermann
2022-03-14 20:56 ` Geert Uytterhoeven
2022-03-14 20:56 ` Geert Uytterhoeven
2022-03-17 11:20 ` Javier Martinez Canillas [this message]
2022-03-13 19:29 ` [PATCH 2/2] fbdev: Fix cfb_imageblit() " Thomas Zimmermann
2022-03-13 19:29 ` Thomas Zimmermann
2022-03-14 8:41 ` Marek Szyprowski
2022-03-17 10:54 ` Daniel Vetter
2022-03-17 10:54 ` Daniel Vetter
2022-03-17 11:22 ` Javier Martinez Canillas
2022-03-24 21:15 ` [2/2] " Guenter Roeck
2022-03-24 21:15 ` Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2022-03-14 2:19 [PATCH 1/2] fbdev: Fix sys_imageblit() " kernel test robot
2022-03-14 14:44 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f867cce1-04dd-a87a-700d-343cc28f188f@redhat.com \
--to=javierm@redhat.com \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.