All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Zhiling Zou <zhilinz@nebusec.ai>, linux-wireless@vger.kernel.org
Cc: vega@nebusec.ai
Subject: Re: [PATCH wireless 1/1] wifi: mac80211: fix fragment length overflow
Date: Mon, 14 Sep 2026 14:58:44 +0200	[thread overview]
Message-ID: <f8abbc475027650afc3293c4317433ccde2e9173.camel@sipsolutions.net> (raw)
In-Reply-To: <ff9b52fe8e4afb8af643ab5e6c638f8fe6596714.1787980055.git.zhilinz@nebusec.ai> (sfid-20260829_073623_742822_6E8076F2)

On Sat, 2026-08-29 at 13:36 +0800, Zhiling Zou wrote:
> The fragment reassembly cache tracks the amount of data in continuation
> fragments in a u16. An oversized fragmented frame can therefore wrap the
> value before it is passed to pskb_expand_head(), leaving the destination
> skb too small for the queued fragments and triggering skb_over_panic().
> 
> Use an unsigned int, matching skb->len, so the accumulator is not
> truncated at 16 bits.
> 
> Fixes: 3a11ce08c45b ("mac80211: add fragment cache to sta_info")
> Cc: stable@vger.kernel.org

I'm not sure this is reachable in real hardware - there are PHY limits
on frame sizes too... it might be though with VHT or so?

> +++ b/net/mac80211/sta_info.h
> @@ -458,7 +458,7 @@ struct ieee80211_fragment_entry {
>  	struct sk_buff_head skb_list;
>  	unsigned long first_frag_time;
>  	u16 seq;
> -	u16 extra_len;
> +	unsigned int extra_len;
>  	u16 last_frag;

You could reorder the fields to not add holes, especially if you're
fixing a patch that as trying to make this smaller ...

johannes

      reply	other threads:[~2026-09-14 12:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-29  5:36 [PATCH wireless 0/1] wifi: mac80211: fix fragment length overflow Zhiling Zou
2026-08-29  5:36 ` [PATCH wireless 1/1] " Zhiling Zou
2026-09-14 12:58   ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8abbc475027650afc3293c4317433ccde2e9173.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=vega@nebusec.ai \
    --cc=zhilinz@nebusec.ai \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.