All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Olivain via buildroot <buildroot@buildroot.org>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/systemd: Bump version to 261
Date: Sun, 05 Jul 2026 11:28:26 +0200	[thread overview]
Message-ID: <f8acb67726efbb68c6c64e99d87ccfe5@free.fr> (raw)
In-Reply-To: <20260621224313.3061196-1-jarkko@kernel.org>

Hi Jarkko,

Thanks for the patch.

On 22/06/2026 00:43, Jarkko Sakkinen via buildroot wrote:
> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>

systemd is not a trivial package to bump, when updating its
major version.

Could you add at least a link to the upstream NEWS file in the commit 
log:
https://github.com/systemd/systemd/blob/v261/NEWS
and summarize what are the important changes relevant to Buildroot,
since the previous v258.7 version?

See for example the last major bump for example:
https://gitlab.com/buildroot.org/buildroot/-/commit/c38d7326e093f45252c01e241d0faf6b04023e02

> ---
>  package/systemd/systemd.hash | 2 +-
>  package/systemd/systemd.mk   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/systemd/systemd.hash 
> b/package/systemd/systemd.hash
> index e96d3ba7ad..1c82877a4a 100644
> --- a/package/systemd/systemd.hash
> +++ b/package/systemd/systemd.hash
> @@ -1,5 +1,5 @@
>  # sha256 locally computed
> -sha256  
> 6bd311c25f00d634ae3b4544d582e27df0d4166e6ba3d403b18b3129d7f44cae  
> systemd-258.7.tar.gz
> +sha256  
> f1c2e6a0d19ea5cae946386eb288432de12f3c6b7730cdb0d2a06f8ab8e3f8dc  
> systemd-261.tar.gz
>  sha256  
> ac4985facb553559981f507982444d779115e3e3a4c8b7847ae956198490c1b3  
> LICENSE.GPL2
>  sha256  
> 6d9bb3b7fc818a8facc4cc296060a0883fef8710d6498f86165335846e82ee9d  
> LICENSE.LGPL2.1
>  sha256  
> c9e7bf5b7c243c719b8b43c36158effb9b54c5e80abc9d82e4b2d4b2a4aa64ad  
> LICENSES/alg-sha1-public-domain.txt

Running "make systemd-legal-info" fails. The license files changed
upstream. Could you update the hashes and summarize what has changed in
the commit log, please?

> diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
> index 3223915d40..9a0b5652e8 100644
> --- a/package/systemd/systemd.mk
> +++ b/package/systemd/systemd.mk
> @@ -19,7 +19,7 @@
>  # - Diff sysusers.d with the previous version
>  # - Diff factory/etc/nsswitch.conf with the previous version
>  #   (details are often sprinkled around in README and manpages)
> -SYSTEMD_VERSION = 258.7
> +SYSTEMD_VERSION = 261

The systemd package has a comment describing few checks that are needed
when bumping systemd in Buildroot:
https://gitlab.com/buildroot.org/buildroot/-/blob/2026.05/package/systemd/systemd.mk?ref_type=tags#L7-L21

The first point applies: the kernel version requirement was increased
from 5.4 to 5.10 in:
https://github.com/systemd/systemd/commit/1aeba33d8ffcc4882566881420e1106c9dff61f3

This change should be reflected at least in:
package/systemd/Config.in (BR2_PACKAGE_SYSTEMD depends and comments)
and
system/Config.in (BR2_INIT_SYSTEMD)

You can review changes running the command in the systemd repository:
git diff v258.7..v261 -- README

This is also observable by running the Buildroot runtime testsuite for
systemd:
https://gitlab.com/jolivain/buildroot/-/pipelines/2652633093

You can run it locally with the command:

utils/docker-run support/testing/run-tests \
     -k -d dl -o output_folder tests.init.test_systemd

systemd also received new meson build options. You can quickly review
those running the command in systemd repository:
git diff v258.7..v261 -- meson_options.txt

Those should be either included in systemd.mk (conditionally or
unconditionally), or eventually the commit log should describe
why no change is needed for a given option.

>  SYSTEMD_SITE = $(call github,systemd,systemd,v$(SYSTEMD_VERSION))
>  SYSTEMD_LICENSE = \
>  	LGPL-2.1+, \
> --
> 2.47.3

Could you rework this patch and send a v2 please?

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2026-07-05  9:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-21 22:43 [Buildroot] [PATCH] package/systemd: Bump version to 261 Jarkko Sakkinen via buildroot
2026-07-05  9:28 ` Julien Olivain via buildroot [this message]
2026-07-09 13:59   ` Jarkko Sakkinen via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8acb67726efbb68c6c64e99d87ccfe5@free.fr \
    --to=buildroot@buildroot.org \
    --cc=jarkko@kernel.org \
    --cc=ju.o@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.