[Cluster-devel] Re: [RFC PATCH] dlm: enhancing dlm_controld (pcmk) to be able to handle redundant rings

[Jiaju Zhang <jjzhang.linux@gmail.com>]

On Fri, Oct 23, 2009 at 9:05 PM, Andrew Beekhof <andrew@beekhof.net> wrote:
>
> On Fri, Oct 23, 2009 at 12:38 PM, jjzhang <jjzhang.linux@gmail.com> wrote:
> > On Fri, Oct 16, 2009 at 12:17:22PM +0200, Lars Marowsky-Bree wrote:
> >> On 2009-10-15T09:51:08, David Teigland <teigland@redhat.com> wrote:
> >>
> >> > On Thu, Oct 15, 2009 at 09:43:56AM +0200, Andrew Beekhof wrote:
> >> > > Looks good to me :-)
> >> > > Although it might be nice to have the automated detection in place too.
> >> > >
> >> > > Less things for the admin to get wrong. ?What do you think Dave?
> >> >
> >> > I don't mind, now that I've taken a moment to think how it should work...
> >> > There should be three protocol options, "tcp", "sctp", "detect". ?Detect
> >> > should work by reading the totem/rrp_mode value in setup_ccs().
> >>
> >> Can we then also agree on "detect" being the default?
> >>
> >> (Experience shows that admins will misconfigure just about anything if
> >> they have to deviate from the defaults.)
> >
> > Hello,
> >
> > Below is the improved patch. I have set the "default" as the same logic as
> > "detect", but I'm not sure if this is OK.
>
> I consider that to be the ideal default.
>
> >
> > Thanks a lot for your kindly review and comments :)
>
> Looks good to me.
> Unless anyone objects I'd like to apply this.
>
> ?(Can you resend as an attachment, inline patches have a habit of
> getting mangled)
>

OK, Thanks :)
Please see the attachment.

Thanks,
Jiaju
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dlm-pcmk-config-protocol.diff
Type: text/x-diff
Size: 4397 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20091023/3af24914/attachment.bin>