Re: + mm-memory_hotplug-dont-use-__gfp_hardwall-when-migrating-pages-via-memory-offlining.patch added to mm-unstable branch

[Oscar Salvador <osalvador@suse.de>]

On 2024-12-10 02:47, Andrew Morton wrote:
> ------------------------------------------------------
> From: David Hildenbrand <david@redhat.com>
> Subject: mm/memory_hotplug: don't use __GFP_HARDWALL when migrating
> pages via memory offlining
> Date: Thu, 5 Dec 2024 10:05:08 +0100
> 
> We'll migrate pages allocated by other context; respecting the cpuset 
> of
> the memory offlining context when allocating a migration target does 
> not
> make sense.
> 
> Drop the __GFP_HARDWALL by using GFP_KERNEL.
> 
> Note that in an ideal world, migration code could figure out the cpuset
> of the original context and take that into consideration.
> 
> Link: 
> https://lkml.kernel.org/r/20241205090508.2095225-3-david@redhat.com
> Signed-off-by: David Hildenbrand <david@redhat.com>
> Suggested-by: Vlastimil Babka <vbabka@suse.cz>
> Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
> Cc: Oscar Salvador <osalvador@suse.de>
> Cc: Zi Yan <ziy@nvidia.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

I would swear I acked this upstream:

Acked-by: Oscar Salvador <osalvador@suse.de>

> ---
> 
>  mm/memory_hotplug.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> ---
> a/mm/memory_hotplug.c~mm-memory_hotplug-dont-use-__gfp_hardwall-when-migrating-pages-via-memory-offlining
> +++ a/mm/memory_hotplug.c
> @@ -1838,7 +1838,7 @@ put_folio:
>  		nodemask_t nmask = node_states[N_MEMORY];
>  		struct migration_target_control mtc = {
>  			.nmask = &nmask,
> -			.gfp_mask = GFP_USER | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL,
> +			.gfp_mask = GFP_KERNEL | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL,
>  			.reason = MR_MEMORY_HOTPLUG,
>  		};
>  		int ret;
> _
> 
> Patches currently in -mm which might be from david@redhat.com are
> 
> docs-tmpfs-update-the-large-folios-policy-for-tmpfs-and-shmem.patch
> mm-memory_hotplug-move-debug_pagealloc_map_pages-into-online_pages_range.patch
> mm-page_isolation-dont-pass-gfp-flags-to-isolate_single_pageblock.patch
> mm-page_isolation-dont-pass-gfp-flags-to-start_isolate_page_range.patch
> mm-page_alloc-make-__alloc_contig_migrate_range-static.patch
> mm-page_alloc-sort-out-the-alloc_contig_range-gfp-flags-mess.patch
> mm-page_alloc-forward-the-gfp-flags-from-alloc_contig_range-to-post_alloc_hook.patch
> powernv-memtrace-use-__gfp_zero-with-alloc_contig_pages.patch
> mm-hugetlb-dont-map-folios-writable-without-vm_write-when-copying-during-fork.patch
> fs-proc-vmcore-convert-vmcore_cb_lock-into-vmcore_mutex.patch
> fs-proc-vmcore-replace-vmcoredd_mutex-by-vmcore_mutex.patch
> fs-proc-vmcore-disallow-vmcore-modifications-while-the-vmcore-is-open.patch
> fs-proc-vmcore-prefix-all-pr_-with-vmcore.patch
> fs-proc-vmcore-move-vmcore-definitions-out-of-kcoreh.patch
> fs-proc-vmcore-factor-out-allocating-a-vmcore-range-and-adding-it-to-a-list.patch
> fs-proc-vmcore-factor-out-freeing-a-list-of-vmcore-ranges.patch
> fs-proc-vmcore-introduce-proc_vmcore_device_ram-to-detect-device-ram-ranges-in-2nd-kernel.patch
> virtio-mem-mark-device-ready-before-registering-callbacks-in-kdump-mode.patch
> virtio-mem-remember-usable-region-size.patch
> virtio-mem-support-config_proc_vmcore_device_ram.patch
> s390-kdump-virtio-mem-kdump-support-config_proc_vmcore_device_ram.patch
> mm-page_alloc-conditionally-split-pageblock_order-pages-in-free_one_page-and-move_freepages_block_isolate.patch
> mm-page_isolation-fixup-isolate_single_pageblock-comment-regarding-splitting-free-pages.patch
> mm-page_alloc-dont-use-__gfp_hardwall-when-migrating-pages-via-alloc_contig.patch
> mm-memory_hotplug-dont-use-__gfp_hardwall-when-migrating-pages-via-memory-offlining.patch

-- 
Oscar Salvador
SUSE Labs