From: David Ahern <dsahern@kernel.org>
To: Gedalya Nie <gedalya@gedalya.net>, netdev@vger.kernel.org
Subject: Re: [PATCH v3] iproute2: color: default to dark background
Date: Wed, 29 May 2024 10:23:37 -0600 [thread overview]
Message-ID: <f8dc2692-6a17-431c-95de-ed32c0b82d59@kernel.org> (raw)
In-Reply-To: <E1s9tE4-00000006L4I-46tH@ws2.gedalya.net>
On 5/22/24 12:43 PM, Gedalya Nie wrote:
> Since the COLORFGBG environment variable isn't always there, and
> anyway it seems that terminals and consoles more commonly default
> to dark backgrounds, make that assumption here.
Huge assumption. For example, I have one setup that defaults to dark
mode and another that defaults to light mode.
>
> Currently the iproute2 tools produce output that is hard to read
> when color is enabled and the background is dark.
I agree with that statement, but the tools need to figure out the dark
vs light and adjust. We can't play games and guess what the right
default is.
--
pw-bot: reject
next prev parent reply other threads:[~2024-05-29 16:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 18:43 [PATCH v3] iproute2: color: default to dark background Gedalya Nie
2024-05-29 16:23 ` David Ahern [this message]
2024-05-29 16:36 ` Gedalya
2024-05-29 17:51 ` Edward Cree
2024-05-29 18:11 ` Stephen Hemminger
2024-05-30 22:58 ` Dragan Simic
2024-05-29 18:12 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8dc2692-6a17-431c-95de-ed32c0b82d59@kernel.org \
--to=dsahern@kernel.org \
--cc=gedalya@gedalya.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.