From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4A74CDB466 for ; Mon, 22 Jun 2026 01:00:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Type:Content-Transfer-Encoding:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:References:To:MIME-Version:Date: Message-ID:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7zaFKFtFRhIfVQN5HEsXjydcD1i98i/pAsYmo+T5jOQ=; b=B7Cim3zlR4ZtPeCzmT+wRyyGPx UKq8TZ1AiOn7X52vRM5bgRRpReSUuTTVkbyWBdwJmcwZ2sfuAmGif5r0LOu10+EpfHidGVmSjbjzm CyKUndoAHSF+PUOSE8gK6IGxOEWWEP2f3S3cHe6WsTKq0FvTts5766atjKl34an6HY/g=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wbT18-0007V0-DP; Mon, 22 Jun 2026 01:00:03 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wbT17-0007UH-6W for linux-f2fs-devel@lists.sourceforge.net; Mon, 22 Jun 2026 01:00:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:To:Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=aLD9lNOZFWsM9PtE4UBaXnrH9y0CjExM9Xpo3tNlLiw=; b=Cp59okNakqW+lclstEoyZAQCAS Ui3hTMfRZ/xactyH+IwGENvztV+Nap1FFTcj7qwi/WrVD8t2v5M0Y5/e7tqaWJa83AK2FsnHA9NMZ L8jbn/oUtYd7tCCCXZQCo3+sD+t7z91+4/1SpXxwgfWr5amZp8wEQdjtsvx8XzPvfqFU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To: Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=aLD9lNOZFWsM9PtE4UBaXnrH9y0CjExM9Xpo3tNlLiw=; b=frYngiH56vTmoV5GQcRTTCRPdE w+VMJ3ahQ0wcVYBO1zCudIfzl+GQaYZNs3tLcA2xM6d1a/wrTm9phryrPiNNlRwtfH5zFACm3xOfE kVDeHchnanuCfXmGczmr7h3WE0r0GBbWWOIQO6MKCnIQTGXoHDmtsCox7xNf7h/0h20I=; Received: from sea.source.kernel.org ([172.234.252.31]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wbT16-00019A-HL for linux-f2fs-devel@lists.sourceforge.net; Mon, 22 Jun 2026 01:00:01 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id A81C340049; Mon, 22 Jun 2026 00:59:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD7891F000E9; Mon, 22 Jun 2026 00:59:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782089995; bh=aLD9lNOZFWsM9PtE4UBaXnrH9y0CjExM9Xpo3tNlLiw=; h=Date:Cc:Subject:To:References:From:In-Reply-To; b=BaBvLTAdy0+9JQsqNh6KfPVosiCdccWLeSroO4C8T40UGcZ8flFkhoshGaq8lc6Yl EsZ0vUM4tYH6JdzDGBjlQsrFuAJPt4U3gslvulbIxFGnqgaW9GRhpz4Z4qCLZ6rhfV bxkizgbW6Av0PCm6zSi/W+aWjBCklrCIcXXVlrtYaxBvwgM5+NodC7NHEUvQiPN2Lo j/NeubuUpOQGzK0CjXMjRWnJs+x+27JInx66EX9YkBfhdzAzkzBdq6I0IuTZiANbTO t2Ecw55T7tv+0cHHQY5aEuNzEt26tcKB1JHmt599M9gqBp7K5LoVMKX/Dn1Z6femDC ehJc+xgVIVcgw== Message-ID: Date: Mon, 22 Jun 2026 08:59:51 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Deepanshu Kartikey , jaegeuk@kernel.org References: <20260510042336.94751-1-kartikey406@gmail.com> Content-Language: en-US In-Reply-To: X-Headers-End: 1wbT16-00019A-HL Subject: Re: [f2fs-dev] [PATCH v2] f2fs: initialize ino_entry_info before checkpoint load X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chao Yu via Linux-f2fs-devel Reply-To: Chao Yu Cc: stable@kernel.org, syzbot+eec8f2693d71386bd600@syzkaller.appspotmail.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gNi8yMS8yNiAxNjoxOCwgRGVlcGFuc2h1IEthcnRpa2V5IHdyb3RlOgo+IE9uIFN1biwgTWF5 IDEwLCAyMDI2IGF0IDk6NTPigK9BTSBEZWVwYW5zaHUgS2FydGlrZXkKPiA8a2FydGlrZXk0MDZA Z21haWwuY29tPiB3cm90ZToKPj4KPj4gV2hlbiBmMmZzX2dldF92YWxpZF9jaGVja3BvaW50KCkg ZmFpbHMgZHVyaW5nIG1vdW50IChlLmcuIGR1ZSB0byBhbgo+PiBpbnZhbGlkIGNoZWNrcG9pbnQg Q1JDIG9uIGEgbWFsZm9ybWVkIGltYWdlKSwgZjJmc19maWxsX3N1cGVyKCkgdGFrZXMKPj4gYW4g ZXJyb3IgcGF0aCB0aGF0IGV2ZW50dWFsbHkgY2FsbHMgaXB1dCgpIG9uIHRoZSByb290IGlub2Rl LiBUaGlzCj4+IGludm9rZXMgZjJmc19kcm9wX2lub2RlKCkgLT4gZjJmc19leGlzdF93cml0dGVu X2RhdGEoKSwgd2hpY2ggYWNxdWlyZXMKPj4gc2JpLT5pbVtdLT5pbm9fbG9jay4gSG93ZXZlciwg ZjJmc19pbml0X2lub19lbnRyeV9pbmZvKCkgaGFzIG5vdCBydW4KPj4geWV0IGF0IHRoaXMgcG9p bnQsIHNvIHRoZSBzcGlubG9jayBpcyB1bmluaXRpYWxpemVkIGFuZCBsb2NrZGVwCj4+IGNvbXBs YWluczoKPj4KPj4gICAgRjJGUy1mcyAobG9vcDApOiBpbnZhbGlkIGNyYyB2YWx1ZQo+PiAgICBG MkZTLWZzIChsb29wMCk6IEZhaWxlZCB0byBnZXQgdmFsaWQgRjJGUyBjaGVja3BvaW50Cj4+ICAg IElORk86IHRyeWluZyB0byByZWdpc3RlciBub24tc3RhdGljIGtleS4KPj4gICAgVGhlIGNvZGUg aXMgZmluZSBidXQgbmVlZHMgbG9ja2RlcCBhbm5vdGF0aW9uLCBvciBtYXliZQo+PiAgICB5b3Ug ZGlkbid0IGluaXRpYWxpemUgdGhpcyBvYmplY3QgYmVmb3JlIHVzZT8KPj4gICAgLi4uCj4+ICAg ICBmMmZzX2V4aXN0X3dyaXR0ZW5fZGF0YSsweDUzLzB4OTAgZnMvZjJmcy9jaGVja3BvaW50LmM6 Nzg3Cj4+ICAgICBmMmZzX2Ryb3BfaW5vZGUrMHhkYS8weGJmMCBmcy9mMmZzL3N1cGVyLmM6MTg1 Mgo+PiAgICAgaXB1dCsweDY1MS8weGU4MCBmcy9pbm9kZS5jOjIwMDkKPj4gICAgIGYyZnNfZmls bF9zdXBlcisweDYwNDcvMHg3ODUwIGZzL2YyZnMvc3VwZXIuYzo1NDYxCj4+Cj4+IE1vdmUgZjJm c19pbml0X2lub19lbnRyeV9pbmZvKCkgdG8gYmVmb3JlIGYyZnNfZ2V0X3ZhbGlkX2NoZWNrcG9p bnQoKQo+PiBzbyB0aGF0IHNiaS0+aW1bXSBpcyBhbHdheXMgZnVsbHkgaW5pdGlhbGl6ZWQgYmVm b3JlIGFueSBlcnJvciBwYXRoCj4+IGNhbiB0cmlnZ2VyIGlwdXQoKSAtPiBmMmZzX2Ryb3BfaW5v ZGUoKS4gVGhlIGluaXQgZnVuY3Rpb24gb25seQo+PiBkZXBlbmRzIG9uIHJhdyBzdXBlcmJsb2Nr IGZpZWxkcyAoQkxLU19QRVJfU0VHLCBGMkZTX0NQX1BBQ0tTLAo+PiBOUl9DVVJTRUdfUEVSU0lT VF9UWVBFLCBfX2NwX3BheWxvYWQpLCB3aGljaCBhcmUgcG9wdWxhdGVkIHdlbGwKPj4gYmVmb3Jl IGNoZWNrcG9pbnQgbG9hZCwgc28gdGhlIG1vdmUgaXMgc2FmZS4KPj4KPj4gRml4ZXM6IDMwNjNj ODA3NzZlMyAoImYyZnM6IGFub3RoZXIgd2F5IHRvIHNldCBsYXJnZSBmb2xpbyBieSByZW1lbWJl cmluZyBpbm9kZSBudW1iZXIiKQo+PiBDYzogc3RhYmxlQGtlcm5lbC5vcmcKPj4gUmVwb3J0ZWQt Ynk6IHN5emJvdCtlZWM4ZjI2OTNkNzEzODZiZDYwMEBzeXprYWxsZXIuYXBwc3BvdG1haWwuY29t Cj4+IENsb3NlczogaHR0cHM6Ly9zeXprYWxsZXIuYXBwc3BvdC5jb20vYnVnP2V4dGlkPWVlYzhm MjY5M2Q3MTM4NmJkNjAwCj4+IFRlc3RlZC1ieTogc3l6Ym90K2VlYzhmMjY5M2Q3MTM4NmJkNjAw QHN5emthbGxlci5hcHBzcG90bWFpbC5jb20KPj4gU2lnbmVkLW9mZi1ieTogRGVlcGFuc2h1IEth cnRpa2V5IDxrYXJ0aWtleTQwNkBnbWFpbC5jb20+Cj4+IC0tLQo+PiBDaGFuZ2VzIGluIHYyOgo+ PiAgIC0gQWRkIEZpeGVzOiB0YWcgKHN1Z2dlc3RlZCBieSBDaGFvIFl1KQo+PiAgIC0gQWRkIENj OiBzdGFibGVAa2VybmVsLm9yZwo+PiAtLS0KPj4gICBmcy9mMmZzL3N1cGVyLmMgfCA5ICsrKysr KystLQo+PiAgIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0p Cj4+Cj4+IGRpZmYgLS1naXQgYS9mcy9mMmZzL3N1cGVyLmMgYi9mcy9mMmZzL3N1cGVyLmMKPj4g aW5kZXggYzZhZmRiZDZlMWNkLi42YTIzMWE1YjBkNjIgMTAwNjQ0Cj4+IC0tLSBhL2ZzL2YyZnMv c3VwZXIuYwo+PiArKysgYi9mcy9mMmZzL3N1cGVyLmMKPj4gQEAgLTUxNDAsNiArNTE0MCwxMyBA QCBzdGF0aWMgaW50IGYyZnNfZmlsbF9zdXBlcihzdHJ1Y3Qgc3VwZXJfYmxvY2sgKnNiLCBzdHJ1 Y3QgZnNfY29udGV4dCAqZmMpCj4+ICAgICAgICAgICAgICAgICAgZ290byBmcmVlX3BhZ2VfYXJy YXlfY2FjaGU7Cj4+ICAgICAgICAgIH0KPj4KPj4gKyAgICAgICAvKgo+PiArICAgICAgICAqIElu aXRpYWxpemUgaW5vIGVudHJ5IGluZm8gZWFybHkgc28gZjJmc19kcm9wX2lub2RlIC0+Cj4+ICsg ICAgICAgICogZjJmc19leGlzdF93cml0dGVuX2RhdGEgY2FuIHNhZmVseSB0YWtlIGltLT5pbm9f bG9jayBpZiBtb3VudAo+PiArICAgICAgICAqIGZhaWxzIGFmdGVyIHRoaXMgcG9pbnQgYW5kIHRy aWdnZXJzIGlwdXQgb24gY2xlYW51cC4KPj4gKyAgICAgICAgKi8KPj4gKyAgICAgICBmMmZzX2lu aXRfaW5vX2VudHJ5X2luZm8oc2JpKTsKPj4gKwo+PiAgICAgICAgICBlcnIgPSBmMmZzX2dldF92 YWxpZF9jaGVja3BvaW50KHNiaSk7Cj4+ICAgICAgICAgIGlmIChlcnIpIHsKPj4gICAgICAgICAg ICAgICAgICBmMmZzX2VycihzYmksICJGYWlsZWQgdG8gZ2V0IHZhbGlkIEYyRlMgY2hlY2twb2lu dCIpOwo+PiBAQCAtNTE4NCw4ICs1MTkxLDYgQEAgc3RhdGljIGludCBmMmZzX2ZpbGxfc3VwZXIo c3RydWN0IHN1cGVyX2Jsb2NrICpzYiwgc3RydWN0IGZzX2NvbnRleHQgKmZjKQo+Pgo+PiAgICAg ICAgICBmMmZzX2luaXRfZXh0ZW50X2NhY2hlX2luZm8oc2JpKTsKPj4KPj4gLSAgICAgICBmMmZz X2luaXRfaW5vX2VudHJ5X2luZm8oc2JpKTsKPj4gLQo+PiAgICAgICAgICBmMmZzX2luaXRfZnN5 bmNfbm9kZV9pbmZvKHNiaSk7Cj4+Cj4+ICAgICAgICAgIC8qIHNldHVwIGNoZWNrcG9pbnQgcmVx dWVzdCBjb250cm9sIGFuZCBzdGFydCBjaGVja3BvaW50IGlzc3VlIHRocmVhZCAqLwo+PiAtLQo+ PiAyLjQzLjAKPj4KPiAKPiBIaSBDaGFvLAo+IAo+IFBsZWFzZSBsZXQgbWUga25vdyB0aGUgc3Rh dHVzIG9mIHRoaXMgcGF0Y2guIFRoaXMgaXMgYWxyZWFkeSAiUmV2aWV3ZWQtYnk6IiB5b3UuCgpo dHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC9qYWVnZXVrL2Yy ZnMuZ2l0L2NvbW1pdC8/aD1kZXYtdGVzdCZpZD0wNjVhNmY4Y2QyM2E5Mjk3YjU0M2RjZWM5MTNm ZWIzY2I3ODdhMjVlCgpJdCB3YXMgbWVyZ2VkLCBob3dldmVyLCBJIHRoaW5rIGl0IHNob3VsZCBi ZSByZXZlcnRlZCBiZWNhdXNlIGNvbW1pdCAzMDYzYzgwNzc2ZTMKKCJmMmZzOiBhbm90aGVyIHdh eSB0byBzZXQgbGFyZ2UgZm9saW8gYnkgcmVtZW1iZXJpbmcgaW5vZGUgbnVtYmVyIikgd2FzIHJl bW92ZWQKZnJvbSBkZXYgYnJhbmNoLCB3ZSB3b24ndCBjYWxsIGYyZnNfZXhpc3Rfd3JpdHRlbl9k YXRhKCkgZnJvbSBmMmZzX2Ryb3BfaW5vZGUoKS4KClRoYW5rcywKCj4gCj4gUGxlYXNlIGxldCBt ZSBrbm93IGlmIGFueXRoaW5nIG5lZWRlZCBmcm9tIG15IHNpZGUuCj4gCj4gVGhhbmtzCj4gCj4g RGVlcGFuc2h1IEthcnRpa2V5CgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkxpbnV4LWYyZnMtZGV2ZWwgbWFpbGluZyBsaXN0CkxpbnV4LWYyZnMtZGV2 ZWxAbGlzdHMuc291cmNlZm9yZ2UubmV0Cmh0dHBzOi8vbGlzdHMuc291cmNlZm9yZ2UubmV0L2xp c3RzL2xpc3RpbmZvL2xpbnV4LWYyZnMtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED19C13D8B1 for ; Mon, 22 Jun 2026 00:59:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782089997; cv=none; b=l/Ligj9leGsurdV1g3ApduwDC8vn9q0H+IA8NF8Q5yc97SAJBmI7Bgu0/07rAxD7AjeZnif23Jzw/dBnTP3BzMFsUT1qV1WgajmGXP0ucaLFJ/GX7vnTM6k/q9boi3ArtNd1x6ZM4qRPUg+dSAFWkE1GTOWbYg4FocCJcJ7OJYM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782089997; c=relaxed/simple; bh=dwegT4OwNFgEQtRGZTdDTGQa2jupKVKf0ZtyH1gX6hs=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=rw0Pb/0xHe2v00qfV7XzmSjC7ievOcu5jfpjfBa3pNJfmNoDzA+6hRVwBR98bwdmlY22QIrCvdTMBcrBHWQFfwo1BUOn87/pODH/khXg67uX+GtX3QXtwIhUakjzIJkzC6d1ZD64z3i7HcelYky9iVcUW2hDxopssRUhuoQjXUY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BaBvLTAd; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BaBvLTAd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD7891F000E9; Mon, 22 Jun 2026 00:59:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782089995; bh=aLD9lNOZFWsM9PtE4UBaXnrH9y0CjExM9Xpo3tNlLiw=; h=Date:Cc:Subject:To:References:From:In-Reply-To; b=BaBvLTAdy0+9JQsqNh6KfPVosiCdccWLeSroO4C8T40UGcZ8flFkhoshGaq8lc6Yl EsZ0vUM4tYH6JdzDGBjlQsrFuAJPt4U3gslvulbIxFGnqgaW9GRhpz4Z4qCLZ6rhfV bxkizgbW6Av0PCm6zSi/W+aWjBCklrCIcXXVlrtYaxBvwgM5+NodC7NHEUvQiPN2Lo j/NeubuUpOQGzK0CjXMjRWnJs+x+27JInx66EX9YkBfhdzAzkzBdq6I0IuTZiANbTO t2Ecw55T7tv+0cHHQY5aEuNzEt26tcKB1JHmt599M9gqBp7K5LoVMKX/Dn1Z6femDC ehJc+xgVIVcgw== Message-ID: Date: Mon, 22 Jun 2026 08:59:51 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, stable@kernel.org, syzbot+eec8f2693d71386bd600@syzkaller.appspotmail.com Subject: Re: [PATCH v2] f2fs: initialize ino_entry_info before checkpoint load To: Deepanshu Kartikey , jaegeuk@kernel.org References: <20260510042336.94751-1-kartikey406@gmail.com> Content-Language: en-US From: Chao Yu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 6/21/26 16:18, Deepanshu Kartikey wrote: > On Sun, May 10, 2026 at 9:53 AM Deepanshu Kartikey > wrote: >> >> When f2fs_get_valid_checkpoint() fails during mount (e.g. due to an >> invalid checkpoint CRC on a malformed image), f2fs_fill_super() takes >> an error path that eventually calls iput() on the root inode. This >> invokes f2fs_drop_inode() -> f2fs_exist_written_data(), which acquires >> sbi->im[]->ino_lock. However, f2fs_init_ino_entry_info() has not run >> yet at this point, so the spinlock is uninitialized and lockdep >> complains: >> >> F2FS-fs (loop0): invalid crc value >> F2FS-fs (loop0): Failed to get valid F2FS checkpoint >> INFO: trying to register non-static key. >> The code is fine but needs lockdep annotation, or maybe >> you didn't initialize this object before use? >> ... >> f2fs_exist_written_data+0x53/0x90 fs/f2fs/checkpoint.c:787 >> f2fs_drop_inode+0xda/0xbf0 fs/f2fs/super.c:1852 >> iput+0x651/0xe80 fs/inode.c:2009 >> f2fs_fill_super+0x6047/0x7850 fs/f2fs/super.c:5461 >> >> Move f2fs_init_ino_entry_info() to before f2fs_get_valid_checkpoint() >> so that sbi->im[] is always fully initialized before any error path >> can trigger iput() -> f2fs_drop_inode(). The init function only >> depends on raw superblock fields (BLKS_PER_SEG, F2FS_CP_PACKS, >> NR_CURSEG_PERSIST_TYPE, __cp_payload), which are populated well >> before checkpoint load, so the move is safe. >> >> Fixes: 3063c80776e3 ("f2fs: another way to set large folio by remembering inode number") >> Cc: stable@kernel.org >> Reported-by: syzbot+eec8f2693d71386bd600@syzkaller.appspotmail.com >> Closes: https://syzkaller.appspot.com/bug?extid=eec8f2693d71386bd600 >> Tested-by: syzbot+eec8f2693d71386bd600@syzkaller.appspotmail.com >> Signed-off-by: Deepanshu Kartikey >> --- >> Changes in v2: >> - Add Fixes: tag (suggested by Chao Yu) >> - Add Cc: stable@kernel.org >> --- >> fs/f2fs/super.c | 9 +++++++-- >> 1 file changed, 7 insertions(+), 2 deletions(-) >> >> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c >> index c6afdbd6e1cd..6a231a5b0d62 100644 >> --- a/fs/f2fs/super.c >> +++ b/fs/f2fs/super.c >> @@ -5140,6 +5140,13 @@ static int f2fs_fill_super(struct super_block *sb, struct fs_context *fc) >> goto free_page_array_cache; >> } >> >> + /* >> + * Initialize ino entry info early so f2fs_drop_inode -> >> + * f2fs_exist_written_data can safely take im->ino_lock if mount >> + * fails after this point and triggers iput on cleanup. >> + */ >> + f2fs_init_ino_entry_info(sbi); >> + >> err = f2fs_get_valid_checkpoint(sbi); >> if (err) { >> f2fs_err(sbi, "Failed to get valid F2FS checkpoint"); >> @@ -5184,8 +5191,6 @@ static int f2fs_fill_super(struct super_block *sb, struct fs_context *fc) >> >> f2fs_init_extent_cache_info(sbi); >> >> - f2fs_init_ino_entry_info(sbi); >> - >> f2fs_init_fsync_node_info(sbi); >> >> /* setup checkpoint request control and start checkpoint issue thread */ >> -- >> 2.43.0 >> > > Hi Chao, > > Please let me know the status of this patch. This is already "Reviewed-by:" you. https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=065a6f8cd23a9297b543dcec913feb3cb787a25e It was merged, however, I think it should be reverted because commit 3063c80776e3 ("f2fs: another way to set large folio by remembering inode number") was removed from dev branch, we won't call f2fs_exist_written_data() from f2fs_drop_inode(). Thanks, > > Please let me know if anything needed from my side. > > Thanks > > Deepanshu Kartikey