From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96DAFD3399B for ; Mon, 28 Oct 2024 16:46:08 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.826848.1241269 (Exim 4.92) (envelope-from ) id 1t5SsD-0000U6-GB; Mon, 28 Oct 2024 16:45:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 826848.1241269; Mon, 28 Oct 2024 16:45:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1t5SsD-0000Tz-Df; Mon, 28 Oct 2024 16:45:45 +0000 Received: by outflank-mailman (input) for mailman id 826848; Mon, 28 Oct 2024 16:45:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1t5SsC-0000Tt-Fs for xen-devel@lists.xenproject.org; Mon, 28 Oct 2024 16:45:44 +0000 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [2a00:1450:4864:20::529]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 12844bd6-954c-11ef-a0c2-8be0dac302b0; Mon, 28 Oct 2024 17:45:43 +0100 (CET) Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-5cb6b2b7127so5294089a12.1 for ; Mon, 28 Oct 2024 09:45:43 -0700 (PDT) Received: from [10.125.226.166] ([185.25.67.249]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5cbb625526csm3511083a12.6.2024.10.28.09.45.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Oct 2024 09:45:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 12844bd6-954c-11ef-a0c2-8be0dac302b0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1730133943; x=1730738743; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=tvbZifJL/khxwyueMcpP2FU2DSZA7pKeUeLy3JaXqE0=; b=VQw78NVOgSiA++9xar+fEj7zCejrDXVI4wDtGw9laMESdxrz2EkZn1T0/jUWQ83ONV 4GE/ZWgE5sUDgdrYMrneLHYZ/YMgfkGu7oAi7zt4QH+3aS/ZiJIa7nP2foDtPWm/Wc2c Sfb3IWhN1Roy0gvFlta6LP5cNRf4N60ISQhxs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730133943; x=1730738743; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tvbZifJL/khxwyueMcpP2FU2DSZA7pKeUeLy3JaXqE0=; b=MfOX9bZ0dy2AA5Qqy3JjLOD3cvjJEKm6W+QgWYUrRkGSAzvVBdurr0HsSvg5iHyyA5 3IyTB9CvmH7AnO0FkZ9DkUixzVajmm1X7RYvn0WhEj+JXagfDoB1IY8y1DNViVj13ala GwPWblyXft6Se3GzPXSfMkEby+7oyrDj9M1k1luscLYXM2uVbslKlFGux+AwwBvLIdTj Bp3BnKw5QvZJ5lOswnpwHWe18SBqJ8dwmuJsCPET6Irfg9pF1OFObzlb5DxipoD4pjTk fa7tFX/ujUpjnOY8UXCN+KTZiKPMlKuOQ4niTfpoB+mcyrRsu2TgfhB9p2gh26YewvCV Li+Q== X-Forwarded-Encrypted: i=1; AJvYcCWYj+Y5bV45ky7OP6Yerec64q8joYTJ/lyr5+2sYzK0gkL4wcnoM637FC3s+rGvJOc7w7LCnrozNoM=@lists.xenproject.org X-Gm-Message-State: AOJu0Yxu+RqHbCHAN2+c8K641xPPq9kCDOM+NqDFXENftTWoa2ILUyvk q/He7/Pi4QznU5mff4PL3O9drYPGtfHCFwZSWk1eYb8bdazoMiD9HODZtYPAGuI= X-Google-Smtp-Source: AGHT+IFcGIJZa+8bo0Xknbz4oeMG2/HIrNLYRfhXEHy1TL0w0I5jTvMHNlB/So4IrO6/ECv6VjFcsg== X-Received: by 2002:a05:6402:350c:b0:5c9:72c7:95a2 with SMTP id 4fb4d7f45d1cf-5cbbfa6223dmr6596744a12.22.1730133942795; Mon, 28 Oct 2024 09:45:42 -0700 (PDT) Message-ID: Date: Mon, 28 Oct 2024 16:45:40 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] earlycpio: constify find_cpio_data()'s "data" parameter To: Jan Beulich Cc: Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" References: <764c0116-88ed-48af-8e53-f2a0f6e850a3@citrix.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 28/10/2024 4:25 pm, Jan Beulich wrote: > On 28.10.2024 17:18, Andrew Cooper wrote: >> On 28/10/2024 4:12 pm, Jan Beulich wrote: >>> On 28.10.2024 17:07, Andrew Cooper wrote: >>>> On 28/10/2024 4:03 pm, Jan Beulich wrote: >>>>> As with 9cbf61445cda ("xen/earlycpio: Drop nextoff parameter"): While >>>>> this is imported from Linux, the parameter not being pointer-to-const is >>>>> dubious in the first place and we're not plausibly going to gain a write >>>>> through it. >>>>> >>>>> Signed-off-by: Jan Beulich >>>> You haven't tried compiling this, have you? >>> Of course I have. Is there any subtlety with compiler versions? Or what >>> else am I missing? >> struct cpio_data's copy of this field is non-const (which you keep on >> noting that new compilers will object to), > New compilers? I'm afraid I'm missing context. With gcc14 the patch builds > fine. I didn't try _older_ ones (but I see no reason why they might object; > see below). > >> and you can't change that >> without breaking the build in microcode. > I don't need to change that, "thanks" to > > cd.data = (void *)dptr; > > casting away const-ness. That is - compilers ought to be fine with the > change; Misra won't like it. You have literally complained about patches of mine on the grounds of "GCC is about to start caring about casting away const on a void pointer". So which is it. > >> Nothing of this form can be taken until the constness is consistent in >> microcode, after which yes it can mostly become const. > We can move there in steps, can't we? Or you can stop trying to insist that I rebase around an incorrect/incomplete patch, just for the sake of the const of one void pointer, which can still be laundered by this function. Especially when you could wait the ~day it will take to get an otherwise-good series in, and then change cpio and get all of the const problems in one go. ~Andrew