From: "Colin King (gmail)" <colin.i.king@gmail.com>
To: Dominique Martinet <asmadeus@codewreck.org>,
Dan Carpenter <dan.carpenter@linaro.org>
Cc: Eric Van Hensbergen <ericvh@kernel.org>,
Latchesar Ionkov <lucho@ionkov.net>,
Christian Schoenebeck <linux_oss@crudebyte.com>,
v9fs@lists.linux.dev, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] fs/9p: remove redundant variable ret
Date: Thu, 7 Nov 2024 09:14:02 +0000 [thread overview]
Message-ID: <f8fa71b8-05c9-4f1a-92fd-e72a8a2d34eb@gmail.com> (raw)
In-Reply-To: <ZyvzuHBSyfI63CT0@codewreck.org>
On 06/11/2024 22:54, Dominique Martinet wrote:
> Dan Carpenter wrote on Thu, Nov 07, 2024 at 12:45:33AM +0300:
>> On Wed, Nov 06, 2024 at 03:22:09PM +0000, Colin Ian King wrote:
>>> The assignments and return checks on ret are redundant. Clean up
>>> the code by just returning the return value from the call to
>>> v9fs_init_inode_cache.
>> [...]
>>
>> Better to delete the whole function and call v9fs_init_inode_cache()
>> directly.
>
> Makes sense, and if we go there delete v9fs_cache_unregister as well so
> the init/destroy pair properly; that also is a single function call.
>
> Thanks!
OK, will do.
Colin
prev parent reply other threads:[~2024-11-07 9:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 15:22 [PATCH][next] fs/9p: remove redundant variable ret Colin Ian King
2024-11-06 21:45 ` Dan Carpenter
2024-11-06 22:54 ` Dominique Martinet
2024-11-07 9:14 ` Colin King (gmail) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8fa71b8-05c9-4f1a-92fd-e72a8a2d34eb@gmail.com \
--to=colin.i.king@gmail.com \
--cc=asmadeus@codewreck.org \
--cc=dan.carpenter@linaro.org \
--cc=ericvh@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.