From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A689C47094 for ; Mon, 7 Jun 2021 18:33:53 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 166B861029 for ; Mon, 7 Jun 2021 18:33:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 166B861029 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C0EED1674; Mon, 7 Jun 2021 20:32:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C0EED1674 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1623090829; bh=3axUphQzW1BbpGyLNTN/dqKwfgXC2Tu3avdx3vGqxiU=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=eEsJT8/rvEpWdwGYfdohQ9SRChM1QDOt2mZRhSvVqNMSYdg2Jh/hxdDKnn9hxew69 2w1C3IHF525jTiR2X9EJ1RdJNtRW5L7/Dva8ijRYSI5ZN29wWbFB+8CydaSpA3MIck oZAQOX1F3A+8qY1XEVe2H79p5AgMLbWhptEGZBnU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 45165F8020D; Mon, 7 Jun 2021 20:32:59 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8674CF80212; Mon, 7 Jun 2021 20:32:57 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 60176F800DF for ; Mon, 7 Jun 2021 20:32:53 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 60176F800DF IronPort-SDR: tmpqjHQrWwYDogEcpq57XnfQ0JaeeRvu4EWD2SBwuL17EJ39cYbqjfnGVvLZSXMCFmXGPSFux5 UYt9L2vI2KRw== X-IronPort-AV: E=McAfee;i="6200,9189,10008"; a="192009337" X-IronPort-AV: E=Sophos;i="5.83,255,1616482800"; d="scan'208";a="192009337" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2021 11:32:48 -0700 IronPort-SDR: hEZZQyqiJNNcgEl8G32to+qOaYgO6xuSYnKHeqp+pMk/0Q4uq1MkZuWkewh+e6OKbXz4HSPqu8 i9roS/djGXHg== X-IronPort-AV: E=Sophos;i="5.83,255,1616482800"; d="scan'208";a="447585633" Received: from dsanc15x-mobl3.amr.corp.intel.com (HELO [10.251.138.253]) ([10.251.138.253]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2021 11:32:46 -0700 Subject: Re: [PATCH 3/4] ASoC: intel: sof_cs42l42: add support for jsl_cs4242_mx98360a To: "Lu, Brent" , "alsa-devel@alsa-project.org" References: <20210606004102.26190-1-brent.lu@intel.com> <20210606004102.26190-4-brent.lu@intel.com> <505c7e46-316c-9fa1-feaa-115f4561ed19@linux.intel.com> From: Pierre-Louis Bossart Message-ID: Date: Mon, 7 Jun 2021 13:32:44 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: Ranjani Sridharan , Guennadi Liakhovetski , "Rojewski, Cezary" , "R, Dharageswari" , Kai Vehmanen , Kuninori Morimoto , Jie Yang , "linux-kernel@vger.kernel.org" , Takashi Iwai , Liam Girdwood , Tzung-Bi Shih , Mark Brown , "Nujella, Sathyanarayana" , "M, Naveen" , "Wang, Rander" , Bard Liao , Fred Oh , "Gopal, Vamshi Krishna" , "Zhi, Yong" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 6/7/21 11:28 AM, Lu, Brent wrote: >>>> >>>> This also looks like we have two topologies configuring the same DAIs >>>> differently on different platforms. >>>> >>>> Why can't we pick one configuration that would work in all cases? >>>> >>> >>> The comment just say we are reusing rt5685's sof-jsl-rt5682-mx98360a.tplg. >>> This patch does not care about the dai sequence. Maybe I should reword >>> the commit log. >> >> I was referring to the bclk frequency, one case uses 2.4 and the other >> 3.072MHz. > > The 2.4MHz setting isn't ready when we enabled this codec so we selected > 3.072MHz. Since we are updating topology for PLL issue soon, we can change > bclk frequency to 2.4MHz as well. How do you think? The 3.072MHz clock will require the 24.576MHz PLL to be on on the SOC/PCH. If you can use 2.4 MHz without any loss of quality and the codec can deal with 25 bit slots with 24-bit data it's better power-wise. We try to use 64.fs only when it's absolutely mandatory, e.g. if the codec or amplifier doesn't support the 25/24 configuration. IIRC this was the case with TI PCM512x and Maxim amps. We've also used the 3.072 MHz bit clock when there are constraints on the clock sources and selectors. This isn't the case on GLK but the SOF commit 0a97c1a92f2d93bd4d45bc99d61e362cd214748c clarified the clock selection for newer platforms, including JSL. In the end we may be forced to use the 3.072 MHz PLL, you'd need to look at the various topologies used with this machine driver. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E85F7C47094 for ; Mon, 7 Jun 2021 18:32:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CFC7361059 for ; Mon, 7 Jun 2021 18:32:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230414AbhFGSel (ORCPT ); Mon, 7 Jun 2021 14:34:41 -0400 Received: from mga04.intel.com ([192.55.52.120]:16994 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230253AbhFGSek (ORCPT ); Mon, 7 Jun 2021 14:34:40 -0400 IronPort-SDR: WqmQKrKM9Ymsgp+O5W66LhrlQPkXDiSdduksF2hqg/ePcjTGV4jiCzJ4yf/5uQzH866aIQV9FB Tlv8jfgXNoUA== X-IronPort-AV: E=McAfee;i="6200,9189,10008"; a="202820972" X-IronPort-AV: E=Sophos;i="5.83,255,1616482800"; d="scan'208";a="202820972" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2021 11:32:48 -0700 IronPort-SDR: hEZZQyqiJNNcgEl8G32to+qOaYgO6xuSYnKHeqp+pMk/0Q4uq1MkZuWkewh+e6OKbXz4HSPqu8 i9roS/djGXHg== X-IronPort-AV: E=Sophos;i="5.83,255,1616482800"; d="scan'208";a="447585633" Received: from dsanc15x-mobl3.amr.corp.intel.com (HELO [10.251.138.253]) ([10.251.138.253]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2021 11:32:46 -0700 Subject: Re: [PATCH 3/4] ASoC: intel: sof_cs42l42: add support for jsl_cs4242_mx98360a To: "Lu, Brent" , "alsa-devel@alsa-project.org" Cc: "Nujella, Sathyanarayana" , Guennadi Liakhovetski , "Rojewski, Cezary" , "R, Dharageswari" , Kuninori Morimoto , Kai Vehmanen , Jie Yang , "linux-kernel@vger.kernel.org" , Takashi Iwai , Liam Girdwood , Tzung-Bi Shih , Mark Brown , Ranjani Sridharan , "M, Naveen" , "Wang, Rander" , Bard Liao , Fred Oh , "Gopal, Vamshi Krishna" , "Zhi, Yong" References: <20210606004102.26190-1-brent.lu@intel.com> <20210606004102.26190-4-brent.lu@intel.com> <505c7e46-316c-9fa1-feaa-115f4561ed19@linux.intel.com> From: Pierre-Louis Bossart Message-ID: Date: Mon, 7 Jun 2021 13:32:44 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/7/21 11:28 AM, Lu, Brent wrote: >>>> >>>> This also looks like we have two topologies configuring the same DAIs >>>> differently on different platforms. >>>> >>>> Why can't we pick one configuration that would work in all cases? >>>> >>> >>> The comment just say we are reusing rt5685's sof-jsl-rt5682-mx98360a.tplg. >>> This patch does not care about the dai sequence. Maybe I should reword >>> the commit log. >> >> I was referring to the bclk frequency, one case uses 2.4 and the other >> 3.072MHz. > > The 2.4MHz setting isn't ready when we enabled this codec so we selected > 3.072MHz. Since we are updating topology for PLL issue soon, we can change > bclk frequency to 2.4MHz as well. How do you think? The 3.072MHz clock will require the 24.576MHz PLL to be on on the SOC/PCH. If you can use 2.4 MHz without any loss of quality and the codec can deal with 25 bit slots with 24-bit data it's better power-wise. We try to use 64.fs only when it's absolutely mandatory, e.g. if the codec or amplifier doesn't support the 25/24 configuration. IIRC this was the case with TI PCM512x and Maxim amps. We've also used the 3.072 MHz bit clock when there are constraints on the clock sources and selectors. This isn't the case on GLK but the SOF commit 0a97c1a92f2d93bd4d45bc99d61e362cd214748c clarified the clock selection for newer platforms, including JSL. In the end we may be forced to use the 3.072 MHz PLL, you'd need to look at the various topologies used with this machine driver.