From: Markus Elfring <Markus.Elfring@web.de>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>, Andi Shyti <andi.shyti@kernel.org>
Subject: Re: [PATCH v2 3/3] i2c: rcar: minor changes to adhere to coding style
Date: Sun, 7 Jul 2024 12:34:36 +0200 [thread overview]
Message-ID: <f93eda7e-e65f-42e9-b96d-e88290201ca0@web.de> (raw)
In-Reply-To: <20240707082848.5424-4-wsa+renesas@sang-engineering.com>
> A newline was missing and closing braces of functions do not need a
> semicolon.
Can there be a need to offer such changes by separate update steps?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc6#n81
…
> +++ b/drivers/i2c/busses/i2c-rcar.c
> @@ -192,7 +192,7 @@ static int rcar_i2c_get_scl(struct i2c_adapter *adap)
>
> return !!(rcar_i2c_read(priv, ICMCR) & FSCL);
>
> -};
> +}
…
How do you think about to omit any blank lines at such source code places?
Regards,
Markus
next prev parent reply other threads:[~2024-07-07 10:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-07 8:28 [PATCH v2 0/3] i2c: rcar: avoid spurious irqs Wolfram Sang
2024-07-07 8:28 ` [PATCH v2 1/3] i2c: rcar: bring hardware to known state when probing Wolfram Sang
2024-07-08 23:19 ` Andi Shyti
2024-07-07 8:28 ` [PATCH v2 2/3] i2c: rcar: WARN about spurious irqs Wolfram Sang
2024-07-07 8:28 ` [PATCH v2 3/3] i2c: rcar: minor changes to adhere to coding style Wolfram Sang
2024-07-07 10:34 ` Markus Elfring [this message]
2024-07-07 11:06 ` Wolfram Sang
2024-07-08 9:50 ` Wolfram Sang
2024-07-08 22:26 ` Andi Shyti
2024-07-10 6:29 ` Wolfram Sang
2024-07-10 8:02 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f93eda7e-e65f-42e9-b96d-e88290201ca0@web.de \
--to=markus.elfring@web.de \
--cc=andi.shyti@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.