Re: [PATCH mptcp-next v5 0/9] BPF path manager, part 4

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 20/02/2025 03:57, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> v5:
>  - use "struct mptcp_pm_param *param" as unified parameters for all
>    interfaces.
>  - register in-kernel mptcp_pm_ops too.
>  - only implement two interfaces "get_local_id" and "get_priority" in
>    this set.
> 
> v4:
>  - include a new patch "define BPF path manager type".
> 
>  - add new interfaces:
> 	created established closed
> 	listerner_created listener_closed
> 
>  - rename interfaces as:
> 	address_announced address_removed
> 	subflow_established subflow_closed
> 	get_priority set_priority
> 
>  - rename functions as:
> 	mptcp_pm_validate
> 	mptcp_pm_register
> 	mptcp_pm_unregister
> 	mptcp_pm_initialize
> 	mptcp_pm_release

Thank you for the new PM ops, and the different modifications, that
looks clearer!

I have some comments, mainly about the new "struct mptcp_pm_param
*param" that seems causing more issues (noises) than solving some I think.

Please see my individual comments.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.