From: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
To: Jeffrey Hugo <quic_jhugo@quicinc.com>, dri-devel@lists.freedesktop.org
Cc: oded.gabbay@gmail.com, maciej.falkowski@linux.intel.com,
Andrzej Kacprowski <Andrzej.Kacprowski@intel.com>
Subject: Re: [PATCH 1/6] accel/ivpu: Add missing locks around mmu queues
Date: Mon, 17 Feb 2025 16:26:50 +0100 [thread overview]
Message-ID: <f97d2306-d03b-47f6-836c-c9057e526490@linux.intel.com> (raw)
In-Reply-To: <8b7ef8c3-788e-bf2a-c393-a627397f6e3f@quicinc.com>
Hi,
On 2/14/2025 5:41 PM, Jeffrey Hugo wrote:
> On 2/4/2025 1:46 AM, Jacek Lawrynowicz wrote:
>> From: Andrzej Kacprowski <Andrzej.Kacprowski@intel.com>
>>
>> Multiple threads were accessing mmu cmd queue simultaneously
>> causing sporadic failures in ivpu_mmu_cmdq_sync() function.
>> Protect critical code with mmu mutex.
>
> Describe a scenario in which this can occur? The two functions this patch modify cannot run concurrently from what I can tell.
Functions from this diff are called in bottom IRQ handler when memory faults are detected.
The CMDQ is also accessed from IOCTLs when mapping/unmapping buffers in NPU MMU (ivpu_mmu_invalidate_tlb()).
Jacek
next prev parent reply other threads:[~2025-02-17 15:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 8:46 [PATCH 0/6] accel/ivpu: Changes for 6.15 2025-02-04 Jacek Lawrynowicz
2025-02-04 8:46 ` [PATCH 1/6] accel/ivpu: Add missing locks around mmu queues Jacek Lawrynowicz
2025-02-14 16:41 ` Jeffrey Hugo
2025-02-17 15:26 ` Jacek Lawrynowicz [this message]
2025-02-18 15:52 ` Jeffrey Hugo
2025-02-04 8:46 ` [PATCH 2/6] accel/ivpu: Prevent runtime suspend during context abort work Jacek Lawrynowicz
2025-02-14 16:49 ` Jeffrey Hugo
2025-02-17 15:33 ` Jacek Lawrynowicz
2025-02-18 15:48 ` Jeffrey Hugo
2025-02-04 8:46 ` [PATCH 3/6] accel/ivpu: Add debugfs interface for setting HWS priority bands Jacek Lawrynowicz
2025-02-14 16:51 ` Jeffrey Hugo
2025-02-04 8:46 ` [PATCH 4/6] accel/ivpu: Allow to import single buffer into multiple contexts Jacek Lawrynowicz
2025-02-14 16:53 ` Jeffrey Hugo
2025-02-04 8:46 ` [PATCH 5/6] accel/ivpu: Add test modes to toggle clock relinquish disable Jacek Lawrynowicz
2025-02-14 16:59 ` Jeffrey Hugo
2025-02-04 8:46 ` [PATCH 6/6] accel/ivpu: Implement D0i2 disable test mode Jacek Lawrynowicz
2025-02-14 17:04 ` Jeffrey Hugo
2025-02-17 15:35 ` Jacek Lawrynowicz
2025-02-10 9:48 ` [PATCH 0/6] accel/ivpu: Changes for 6.15 2025-02-04 Jacek Lawrynowicz
2025-02-12 10:20 ` Thomas Zimmermann
2025-02-12 12:59 ` Maxime Ripard
2025-02-12 13:27 ` Jacek Lawrynowicz
2025-02-12 15:52 ` Jeffrey Hugo
2025-02-13 14:17 ` Thomas Zimmermann
2025-02-14 15:47 ` Jeffrey Hugo
2025-02-17 16:53 ` Simona Vetter
2025-02-13 14:06 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f97d2306-d03b-47f6-836c-c9057e526490@linux.intel.com \
--to=jacek.lawrynowicz@linux.intel.com \
--cc=Andrzej.Kacprowski@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=maciej.falkowski@linux.intel.com \
--cc=oded.gabbay@gmail.com \
--cc=quic_jhugo@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.